From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 127FE1FF185 for ; Mon, 21 Jul 2025 16:47:33 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A0A5612C25; Mon, 21 Jul 2025 16:48:41 +0200 (CEST) From: Mira Limbeck To: pve-devel@lists.proxmox.com Date: Mon, 21 Jul 2025 16:48:32 +0200 Message-Id: <20250721144832.570040-1-m.limbeck@proxmox.com> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.605 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Subject: [pve-devel] [PATCH proxmox-openid] fix #6541: openid: add missing connector chains X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" With the upgrade to ureq 3 the TLS connectors (native-tls, rustls) now require a transport (tcp) in the chain before it, otherwise they panic. For HTTP Connect proxy support another ConnectProxy connector is required. The new chain, based on the DefaultConnector [0] chain in ureq, needs to have the connectors in the order of: ConnectProxy -> Tcp -> Tls [0] https://github.com/algesten/ureq/blob/3.0.11/src/unversioned/transport/mod.rs#L346 Signed-off-by: Mira Limbeck --- proxmox-openid/src/http_client.rs | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) mode change 100644 => 100755 proxmox-openid/src/http_client.rs diff --git a/proxmox-openid/src/http_client.rs b/proxmox-openid/src/http_client.rs old mode 100644 new mode 100755 index e4628170..7d383d5d --- a/proxmox-openid/src/http_client.rs +++ b/proxmox-openid/src/http_client.rs @@ -4,6 +4,7 @@ use std::io::Read; use http::method::Method; use openidconnect::{HttpRequest, HttpResponse}; +use ureq::unversioned::transport::Connector; // Copied from OAuth2 create, because we want to use ureq with // native-tls. But current OAuth2 crate pulls in rustls, so we cannot @@ -43,7 +44,9 @@ fn ureq_agent() -> Result { } let agent = ureq::Agent::with_parts( config.build(), - ureq::unversioned::transport::NativeTlsConnector::default(), + ureq::unversioned::transport::ConnectProxyConnector::default() + .chain(ureq::unversioned::transport::TcpConnector::default()) + .chain(ureq::unversioned::transport::NativeTlsConnector::default()), ureq::unversioned::resolver::DefaultResolver::default(), ); -- 2.47.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel