From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 4CC2D1FF185 for ; Mon, 21 Jul 2025 14:10:58 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id DEDF7CF65; Mon, 21 Jul 2025 14:11:35 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Mon, 21 Jul 2025 14:10:53 +0200 Message-ID: <20250721121124.77526-9-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250721121124.77526-1-f.ebner@proxmox.com> References: <20250721121124.77526-1-f.ebner@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1753099880987 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.027 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH qemu-server 8/9] resolve destination disk format helper: drop unused variable X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" The $scfg variable in resolve_dst_disk_format() has been unused since commit 1f961e51 ("resolve destination disk format helper: use volume format from storage layer"). Signed-off-by: Fiona Ebner --- src/PVE/QemuServer.pm | 1 - 1 file changed, 1 deletion(-) diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm index d7398648..60c390bd 100644 --- a/src/PVE/QemuServer.pm +++ b/src/PVE/QemuServer.pm @@ -7964,7 +7964,6 @@ sub resolve_dst_disk_format { if (!$format) { # if no target format is specified, use the source disk format as hint if ($src_volid) { - my $scfg = PVE::Storage::storage_config($storecfg, $storeid); $format = checked_volume_format($storecfg, $src_volid); } else { return $defFormat; -- 2.47.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel