From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 5B6B61FF17A for ; Fri, 18 Jul 2025 18:26:14 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 31ECF35760; Fri, 18 Jul 2025 18:26:49 +0200 (CEST) From: Stefan Hanreich To: pve-devel@lists.proxmox.com Date: Fri, 18 Jul 2025 18:26:29 +0200 Message-Id: <20250718162638.444705-10-s.hanreich@proxmox.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250718162638.444705-1-s.hanreich@proxmox.com> References: <20250718162638.444705-1-s.hanreich@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.202 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Subject: [pve-devel] [PATCH pve-manager v2 07/16] nic pinning: rename 'nic' parameter to 'interface' X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Cc: Thomas Lamprecht Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" From: Thomas Lamprecht Note that we do greedy matching for CLI parameters names and allow using just a single minus too, so as of now one can stills use shorter variants like `-i IFACE`. Signed-off-by: Thomas Lamprecht Signed-off-by: Stefan Hanreich --- PVE/CLI/proxmox_network_interface_pinning.pm | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/PVE/CLI/proxmox_network_interface_pinning.pm b/PVE/CLI/proxmox_network_interface_pinning.pm index f9d94369a..4b7f72404 100644 --- a/PVE/CLI/proxmox_network_interface_pinning.pm +++ b/PVE/CLI/proxmox_network_interface_pinning.pm @@ -325,10 +325,12 @@ __PACKAGE__->register_method({ parameters => { additionalProperties => 0, properties => { - nic => { - description => 'Only pin a specific NIC.', + # TODO: support a target name or prefix once pve-common supports generic physical ifaces + interface => { + description => 'Only pin a specific interface.', type => 'string', format => 'pve-iface', + default => '', # just for the docs. optional => 1, }, }, @@ -352,20 +354,19 @@ __PACKAGE__->register_method({ } my $code = sub { - my $prefix = 'nic'; + my $prefix = 'nic'; # TODO: make flexible once pve-common supports that. my $ip_links = get_ip_links(); my $pinned = get_pinned(); my $existing_pins = resolve_pinned($ip_links, $pinned); - if ($params->{nic}) { - die "Could not find link with name $params->{nic}" - if !$ip_links->{ $params->{nic} }; + if ($iface) { + die "Could not find link with name '$iface'\n" if !$ip_links->{$iface}; - die "There already exists a pin for NIC $params->{nic}" - if $existing_pins->{ $params->{nic} }; + die "There already exists a pin for NIC '$iface' - aborting.\n" + if $existing_pins->{$iface}; - $ip_links = { $params->{nic} => $ip_links->{ $params->{nic} } }; + $ip_links = { $iface => $ip_links->{$iface} }; } else { for my $iface_name (keys $existing_pins->%*) { delete $ip_links->{$iface_name}; -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel