From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 26EAB1FF17A for ; Fri, 18 Jul 2025 18:25:11 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 547B135366; Fri, 18 Jul 2025 18:26:17 +0200 (CEST) From: Stefan Hanreich To: pve-devel@lists.proxmox.com Date: Fri, 18 Jul 2025 18:26:09 +0200 Message-Id: <20250718162610.443895-2-s.hanreich@proxmox.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250718162610.443895-1-s.hanreich@proxmox.com> References: <20250718162610.443895-1-s.hanreich@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.207 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Subject: [pve-devel] [PATCH pve-manager 1/2] network-interface-pinning: fix subsequent invocations X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" The fix introduced in 5b5db0e67 fixed the scenario where pins were already applied, but broke the case where they weren't yet applied, since now not-yet-applied pins would get overwritten again on subsequent invocations of the pinning tool. Move the check for the same name to the update_etc_network_interfaces call, where it is actually required - instead of filtering already in the resolve_pinned function, which is also used in the generate body to filter eligible links for pinning. Fixes: 5b5db0e67 Signed-off-by: Stefan Hanreich --- PVE/CLI/proxmox_network_interface_pinning.pm | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/PVE/CLI/proxmox_network_interface_pinning.pm b/PVE/CLI/proxmox_network_interface_pinning.pm index 17b507911..8b7127488 100644 --- a/PVE/CLI/proxmox_network_interface_pinning.pm +++ b/PVE/CLI/proxmox_network_interface_pinning.pm @@ -79,7 +79,7 @@ my sub update_etc_network_interfaces { for my $iface_name (keys $old_ifaces->%*) { my $iface = $old_ifaces->{$iface_name}; - if ($existing_pins->{$iface_name}) { + if ($existing_pins->{$iface_name} && $existing_pins->{$iface_name} ne $iface_name) { # reading the interfaces file adds active interfaces to the # configuration - we do not want to include already pinned # interfaces in the new configuration when writing the new @@ -328,8 +328,7 @@ sub resolve_pinned { next; } - $resolved->{ $mac_lookup{$mac} } = $pinned->{$mac} - if $mac_lookup{$mac} ne $pinned->{$mac}; + $resolved->{ $mac_lookup{$mac} } = $pinned->{$mac}; } return $resolved; -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel