From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 4F49B1FF17A for ; Fri, 18 Jul 2025 18:18:48 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 58EBA3528D; Fri, 18 Jul 2025 18:19:46 +0200 (CEST) From: "Max R. Carrara" To: pve-devel@lists.proxmox.com Date: Fri, 18 Jul 2025 18:19:04 +0200 Message-Id: <20250718161905.461482-5-m.carrara@proxmox.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250718161905.461482-1-m.carrara@proxmox.com> References: <20250718161905.461482-1-m.carrara@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1752855550146 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.084 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH v1 pve-esxi-import-tools 4/5] d/control: add python3-pyvmomi (>= 8) as build dependency X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" ... and don't ignore missing imports for pyVmomi in mypy.ini anymore. python3-pyvmomi >= 8 is available only on trixie, which includes a bunch of new type stubs that were previously missing. This means that mypy no longer has to ignore missing imports in regards to pyVmomi. mypy will therefore now complain when it can't find pyVmomi, so any strange behavior regarding type checking of pyVmomi's types should hopefully not happen anymore. Note that pyVim is part of python3-pyvmomi, but still doesn't provide any proper type stubs / hints that mypy can use, so we keep it ignored until it does. Signed-off-by: Max R. Carrara --- debian/control | 1 + mypy.ini | 3 --- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/debian/control b/debian/control index ee74e15..d57b302 100644 --- a/debian/control +++ b/debian/control @@ -38,6 +38,7 @@ Build-Depends: cargo:native (>= 0.65.0~), librust-tokio-1+time-dev, libstd-rust-dev, mypy, + python3-pyvmomi (>= 8), rustc:native, Maintainer: Proxmox Support Team Standards-Version: 4.6.2 diff --git a/mypy.ini b/mypy.ini index e6724c8..0387e66 100644 --- a/mypy.ini +++ b/mypy.ini @@ -1,8 +1,5 @@ [mypy] -[mypy-pyVmomi] -ignore_missing_imports = True - [mypy-pyVim.*] ignore_missing_imports = True -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel