From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 290791FF17A for ; Fri, 18 Jul 2025 14:53:38 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E2FB11E7A6; Fri, 18 Jul 2025 14:54:45 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Fri, 18 Jul 2025 14:51:14 +0200 Message-ID: <20250718125408.133376-4-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250718125408.133376-1-f.ebner@proxmox.com> References: <20250718125408.133376-1-f.ebner@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1752843249178 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.029 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [pve8to9.pm] Subject: [pve-devel] [PATCH manager 3/6] pve8to9: backup retention: increase severity of having 'maxfiles' setting configured X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" The 'maxfiles' setting is dropped with Proxmox VE 9, so make having the setting configured a proper error rather than just a warning. Signed-off-by: Fiona Ebner --- NOTE: for both stable-8 and master PVE/CLI/pve8to9.pm | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/PVE/CLI/pve8to9.pm b/PVE/CLI/pve8to9.pm index cd8ea038..d0f8cff0 100644 --- a/PVE/CLI/pve8to9.pm +++ b/PVE/CLI/pve8to9.pm @@ -649,8 +649,8 @@ sub check_backup_retention_settings { my $pass = 1; - my $maxfiles_msg = "parameter 'maxfiles' is deprecated with PVE 7.x and will be removed in a " - . "future version, use 'prune-backups' instead."; + my $maxfiles_msg = "parameter 'maxfiles' was deprecated with PVE 7.x and is getting dropped" + . " with PVE 9."; eval { my $confdesc = PVE::VZDump::Common::get_confdesc(); @@ -665,12 +665,12 @@ sub check_backup_retention_settings { if (defined($param->{maxfiles})) { $pass = 0; - log_warn("$fn - $maxfiles_msg"); + log_fail("$fn - $maxfiles_msg"); } }; if (my $err = $@) { $pass = 0; - log_warn("unable to parse node's VZDump configuration - $err"); + log_fail("unable to parse node's VZDump configuration - $err"); } my $storage_cfg = PVE::Storage::config(); @@ -680,7 +680,7 @@ sub check_backup_retention_settings { if (defined($scfg->{maxfiles})) { $pass = 0; - log_warn("storage '$storeid' - $maxfiles_msg"); + log_fail("storage '$storeid' - $maxfiles_msg"); } } @@ -690,12 +690,12 @@ sub check_backup_retention_settings { # only warn once, there might be many jobs... if (scalar(grep { defined($_->{maxfiles}) } $vzdump_cron->{jobs}->@*)) { $pass = 0; - log_warn("/etc/pve/vzdump.cron - $maxfiles_msg"); + log_fail("/etc/pve/vzdump.cron - $maxfiles_msg"); } }; if (my $err = $@) { $pass = 0; - log_warn("unable to parse node's VZDump configuration - $err"); + log_fail("unable to parse node's VZDump configuration - $err"); } log_pass("no backup retention problems found.") if $pass; -- 2.47.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel