From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 7299E1FF17A for ; Fri, 18 Jul 2025 13:55:21 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5D81D1C7F6; Fri, 18 Jul 2025 13:56:29 +0200 (CEST) From: Wolfgang Bumiller To: pve-devel@lists.proxmox.com Date: Fri, 18 Jul 2025 13:56:10 +0200 Message-ID: <20250718115626.183425-1-w.bumiller@proxmox.com> X-Mailer: git-send-email 2.47.2 MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1752839783368 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.078 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [qemumigrate.pm] Subject: [pve-devel] [PATCH qemu-server] refuse to migrate volume-chain-snapshots for now X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" When using qcow2 "backing volumes" for snapshots we'd have to copy all of them for local-storage migration. Let's refuse to do this for now and wait until we decide whether this should also happen via replication at some point. Signed-off-by: Wolfgang Bumiller --- src/PVE/QemuMigrate.pm | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/PVE/QemuMigrate.pm b/src/PVE/QemuMigrate.pm index f46bdf40..251fcc79 100644 --- a/src/PVE/QemuMigrate.pm +++ b/src/PVE/QemuMigrate.pm @@ -454,6 +454,10 @@ sub scan_local_volumes { # we cannot migrate snapshots on local storage # exceptions: 'zfspool' or 'qcow2' files (on directory storage) + # + # Note that only qcow2 with in-qcow2 snapshots work - for + # backing-chain snapshots we'd need to copy the entire snapshot + # list (or support replication) die "online storage migration not possible if non-replicated snapshot exists\n" if $self->{running} && !$local_volumes->{$volid}->{replicated}; @@ -464,7 +468,8 @@ sub scan_local_volumes { if (!( $scfg->{type} eq 'zfspool' || ($scfg->{type} eq 'btrfs' && $local_volumes->{$volid}->{format} eq 'raw') - || $local_volumes->{$volid}->{format} eq 'qcow2' + || ($local_volumes->{$volid}->{format} eq 'qcow2' + && !$scfg->{'snapshot-as-volume-chain'}) )) { die "non-migratable snapshot exists\n"; } -- 2.47.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel