From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 8387C1FF165 for ; Thu, 17 Jul 2025 17:27:51 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id F10C13EC86; Thu, 17 Jul 2025 17:28:47 +0200 (CEST) From: Stefan Hanreich To: pve-devel@lists.proxmox.com Date: Thu, 17 Jul 2025 17:28:41 +0200 Message-Id: <20250717152841.397830-7-s.hanreich@proxmox.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250717152841.397830-1-s.hanreich@proxmox.com> References: <20250717152841.397830-1-s.hanreich@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.210 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Subject: [pve-devel] [PATCH pve-manager 4/4] proxmox-network-interface-pinning: fix pinning after reboot X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" We generate a list of existing pins as a reference throughout the pinning tool. It works by reading the existing link files and looking up interfaces with the corresponding MAC address. If pins have already been applied, this would return a mapping of the pinned name to itself (nic0 => nic0). We use this list for filtering what we write to the pending configuration, in order to avoid re-introducing already pinned names to the pending configuration. This reflexive entry would cause the interfaces file generation to filter all pinned network interfaces after reboot, leading to invalid ifupdown2 configuration files. Fix this by filtering entries in the existing-pins list who are reflexive. Signed-off-by: Stefan Hanreich --- PVE/CLI/proxmox_network_interface_pinning.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/PVE/CLI/proxmox_network_interface_pinning.pm b/PVE/CLI/proxmox_network_interface_pinning.pm index b57362c7e..271ec0430 100644 --- a/PVE/CLI/proxmox_network_interface_pinning.pm +++ b/PVE/CLI/proxmox_network_interface_pinning.pm @@ -328,7 +328,8 @@ sub resolve_pinned { next; } - $resolved->{ $mac_lookup{$mac} } = $pinned->{$mac}; + $resolved->{ $mac_lookup{$mac} } = $pinned->{$mac} + if $mac_lookup{$mac} ne $pinned->{$mac}; } return $resolved; -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel