From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 247DE1FF165 for ; Thu, 17 Jul 2025 16:14:41 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1E83A3C104; Thu, 17 Jul 2025 16:15:41 +0200 (CEST) From: Christoph Heiss To: pve-devel@lists.proxmox.com Date: Thu, 17 Jul 2025 16:15:19 +0200 Message-ID: <20250717141530.1471199-4-c.heiss@proxmox.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250717141530.1471199-1-c.heiss@proxmox.com> References: <20250717141530.1471199-1-c.heiss@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1752761735950 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.031 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [firewall.pm] Subject: [pve-devel] [PATCH firewall v4 03/14] firewall: add connmark rule with VMID to all guest chains X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Adds a connmark attribute with the VMID inside to anything flowing in/out the guest, which are also carried over to all conntrack entries. This enables differentiating conntrack entries between VMs for live-migration. Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * no changes Changes v2 -> v3: * rebased on trixie Changes v3 -> v4: * no changes src/PVE/Firewall.pm | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/src/PVE/Firewall.pm b/src/PVE/Firewall.pm index fd5d457..49430b1 100644 --- a/src/PVE/Firewall.pm +++ b/src/PVE/Firewall.pm @@ -2551,11 +2551,14 @@ sub ruleset_chain_add_input_filters { } sub ruleset_create_vm_chain { - my ($ruleset, $chain, $ipversion, $options, $macaddr, $ipfilter_ipset, $direction) = @_; + my ($ruleset, $chain, $ipversion, $options, $macaddr, $ipfilter_ipset, $direction, $vmid) = @_; ruleset_create_chain($ruleset, $chain); my $accept = generate_nfqueue($options); + # needs to be first, to ensure that it gets always applied + ruleset_addrule($ruleset, $chain, "", "-j CONNMARK --set-mark $vmid"); + if (!(defined($options->{dhcp}) && $options->{dhcp} == 0)) { if ($ipversion == 4) { if ($direction eq 'OUT') { @@ -2796,7 +2799,14 @@ sub generate_tap_rules_direction { if ($options->{enable}) { # create chain with mac and ip filter ruleset_create_vm_chain( - $ruleset, $tapchain, $ipversion, $options, $macaddr, $ipfilter_ipset, $direction, + $ruleset, + $tapchain, + $ipversion, + $options, + $macaddr, + $ipfilter_ipset, + $direction, + $vmid, ); ruleset_generate_vm_rules( -- 2.49.0 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel