From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 00A7A1FF16B for ; Tue, 15 Jul 2025 15:56:19 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2B2E93E4E5; Tue, 15 Jul 2025 15:57:05 +0200 (CEST) From: Christoph Heiss To: pve-devel@lists.proxmox.com Date: Tue, 15 Jul 2025 15:55:38 +0200 Message-ID: <20250715135620.1023136-1-c.heiss@proxmox.com> X-Mailer: git-send-email 2.49.0 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.028 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_MSPIKE_H2 0.001 Average reputation (+2) RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [answer.rs, proxmox.com, install.pm, parse-answer.rs, net.pm, runenv.pm] Subject: [pve-devel] [PATCH installer 0/3] run env, auto: fix dhcp hostname/domain retrieval X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" First two patches fix two small, separate issues w.r.t. the automatic retrieval of hostname and search domain from the DHCP lease. First one is a correctness fix for RFC 2132, which specifies that the hostname in the DHCP lease _can_ also contain a fully-qualified name, i.e. .. That can easily be stripped. Second was that in the auto-installer answer file `global.fqdn.domain` can be set to an empty string, which further down the line causes parsing failure and the default `.example.invalid` being set as system FQDN. Both were reported by a user on the community forum [0]. Third patch just runs perltidy on the codebase again, fixing up some recent changes. [0] https://forum.proxmox.com/threads/auto-install-fetching-fqdn-through-dhcp-does-not-set-search-domain-correctly.168369/ Diffstat ======== Christoph Heiss (3): run env: fix dhcp-set hostname containing local domain auto: answer: deserialize empty domain name as `None` install: run `make tidy` Proxmox/Install.pm | 6 ++++-- Proxmox/Install/RunEnv.pm | 8 +++++++- Proxmox/Sys/Net.pm | 12 ++++++++---- proxmox-auto-installer/src/answer.rs | 13 +++++++++++++ proxmox-auto-installer/tests/parse-answer.rs | 1 + ...n_from_dhcp_empty_dhcp_domain_setting.json | 19 +++++++++++++++++++ ...n_from_dhcp_empty_dhcp_domain_setting.toml | 17 +++++++++++++++++ 7 files changed, 69 insertions(+), 7 deletions(-) create mode 100644 proxmox-auto-installer/tests/resources/parse_answer/fqdn_from_dhcp_empty_dhcp_domain_setting.json create mode 100644 proxmox-auto-installer/tests/resources/parse_answer/fqdn_from_dhcp_empty_dhcp_domain_setting.toml -- 2.49.0 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel