From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 5883E1FF17C for ; Wed, 9 Jul 2025 21:46:01 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 40F3314C1F; Wed, 9 Jul 2025 21:46:07 +0200 (CEST) From: Stefan Hanreich To: pve-devel@lists.proxmox.com Date: Wed, 9 Jul 2025 21:45:25 +0200 Message-Id: <20250709194526.560709-7-s.hanreich@proxmox.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250709194526.560709-1-s.hanreich@proxmox.com> References: <20250709194526.560709-1-s.hanreich@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.220 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Subject: [pve-devel] [PATCH pve-network 1/1] controllers: isis: add altname support X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Since this only has an effect on applying the configuration, users will still need to reapply the configuration when an interface changes names / altnames. In order to add full altname support for IS-IS, altname support would need to be implemented in FRR. Signed-off-by: Stefan Hanreich --- Notes: Gabriel is currently working on altname support in FRR [1] [1] https://github.com/FRRouting/frr/pull/19156 src/PVE/Network/SDN/Controllers/IsisPlugin.pm | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/PVE/Network/SDN/Controllers/IsisPlugin.pm b/src/PVE/Network/SDN/Controllers/IsisPlugin.pm index 6e3574d..0ef9fb9 100644 --- a/src/PVE/Network/SDN/Controllers/IsisPlugin.pm +++ b/src/PVE/Network/SDN/Controllers/IsisPlugin.pm @@ -80,9 +80,12 @@ sub generate_controller_config { my @iface_config = ("ip router isis $isis_domain"); + my $altnames = PVE::Network::altname_mapping(); + my @ifaces = PVE::Tools::split_list($isis_ifaces); for my $iface (sort @ifaces) { - push(@{ $config->{frr_interfaces}->{$iface} }, @iface_config); + my $iface_name = $altnames->{$iface} // $iface; + push(@{ $config->{frr_interfaces}->{$iface_name} }, @iface_config); } return $config; -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel