From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 73DEE1FF16B for ; Tue, 1 Jul 2025 17:45:13 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5E3FFA86D; Tue, 1 Jul 2025 17:42:40 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=m5/5in35cPaUiEdenBpXLE6svss81hEoldPpW2uGwBAKM1McZOK6/PBn+QqCzgwOUAAojPR933BnJhPpBV8oFEFLqSbQZxO/gqdj7629Dqx9cpjXao1MshX4k1x+yu5KBxet5T1jZonDDgot6PmDcxuJ+Z1di7oLgaeuLKY+Jt8TILWB+Ua9FpIUp5dhFW6oq6zkwt+0/O5SFRPFb0qd9wTV+uFXFRadySLhoaKjTcKw9PPToFbrk+q3Vwo3bbeHWzT+KuJhy8/P36SUUzLkmP4XAw1QEl9sfkbOMGFKM3e2yBcnB56IRWsu3i1ewortUeICf86o4nycTzYHbFbTdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qOUfUhbNk1JUStQbTNz8IRinUSUexjuMW4gmRhihRK8=; b=LRm3o9HcNFooONK2eriU74pSDTZk2L38MiaVb5KWKs7D7BEGUlDnpnb/Kv2+jc+8OkQgz+B/NOlKKWNFbg6guS8R427toHl6EwVAmjz9owsgWRa7RFtuq9D4hzYj7m6r5aGeqXp5jxUrt7lNb1vN96ymej3Hgs+++/Hkbry3xV92NN2unX8JR78EI4jBfoX9KMm63ZpoMgJ76y5ZmhzGBHREdPmqt7TqtSg9iexv7oViawV8oTPHfGzLhkVkGlNPCYLFdHjgGQyCfcLUsy+RW+MZIPuA5R6pQQLawQ161BOHmaDqcNB4S+JGOzXPr6/lrkccnW87R9ykwpMnmKS10g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=libvirt.dev; dmarc=pass action=none header.from=libvirt.dev; dkim=pass header.d=libvirt.dev; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=libvirt.dev; From: Stelios Vailakakis To: pve-devel@lists.proxmox.com Date: Tue, 1 Jul 2025 15:41:35 +0000 Message-Id: <20250701154135.2387872-1-stelios@libvirt.dev> X-Mailer: git-send-email 2.39.5 X-ClientProxiedBy: BL1PR13CA0101.namprd13.prod.outlook.com (2603:10b6:208:2b9::16) To BYAPR06MB4358.namprd06.prod.outlook.com (2603:10b6:a03:5d::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR06MB4358:EE_|SA1PR06MB8197:EE_ X-MS-Office365-Filtering-Correlation-Id: d0d5d1d4-66fc-4871-05a4-08ddb8b5ca41 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|586017|376014|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?2bS87JOs1KJmvfotj7iypUdInauTT8KBPbKhL2W+lbIh5MyETbBTeuQWV69x?= =?us-ascii?Q?9ZWhFOQdTwINFA/qMMnh+xiw6X8+RJEm6pUf1Ex6v0vkYRneUIyWRqfj40Xm?= =?us-ascii?Q?ysvKRWSdPwoR4yvD/ALNB94IfU9TYM4qYDYBIvdTXYMaLKSZqYEzfaCKz75V?= =?us-ascii?Q?FzIYbYMO1I6wCFLvEqX6hrc9pSTxj6/sB7l9GcMJQhHlW5rUbDJaptjW/UVz?= =?us-ascii?Q?Wom5t/l1sr2lYFh+SwEWgs2SguSy+hMUnORZvIig0Dmy1IdQ8Bj6AKJucSaV?= =?us-ascii?Q?0QwjIWak91u/6DQ00k+tdd5ttQU7tV9Oha5S6ZK3sVY7Ts2ZSAYAGN05Saf8?= =?us-ascii?Q?IPMn1lPblY//qa9Z+FMgqvWNaybyPFaVb0/2EQ+uWOlpmv2DGQCbphrnrtio?= =?us-ascii?Q?ec+MLBLZ4S3L2MIvKhcWbkLofZRm2Sd8Is61wPDrZS+o/KAx1M56EVj5EMk8?= =?us-ascii?Q?VjnQs4OE9bas3TqzXetZSU4gqdLyA5+2iluHBF4VDe+82o/pnIWFlvY1sIMb?= =?us-ascii?Q?03/2vv9MpIxCP0PV62b/YD8rgJet6zPhlGVjB4kdjtbEsAWK/f9AM35Tvleg?= =?us-ascii?Q?dvcEt5JKJ/pYKnuaZDXZeFSismOPm7rzKS1viD5fjnMoU+QFYcAEeQMQ+sN5?= =?us-ascii?Q?WATxOtUQDIzFIFGgs7mJgJgIfg50dQU5zSsBCrahSshiGRStvThCy6i2aOJ3?= =?us-ascii?Q?OhsXRx3N+/5DdANePWzFeN5typiMGeGXm90cqtJDyib/eJuEfPUhZoRTxXKJ?= =?us-ascii?Q?1WAKD3rdSnaS6vekwGW+Grbx4yAPuw8ypd79EREpdqElxfmzOMRUbY5N9bqX?= =?us-ascii?Q?Hxj2HfhLLBSHs+ky0HeazOBERjADy/ye1jSfWavf+HD2L4OkTLGSWZ/qsEoy?= =?us-ascii?Q?y6Fb80+n8RlY3Ai9WMkDX9FDoU4JxhDXBL1QWrO2LsscwTDmjW/M401hKHrH?= =?us-ascii?Q?2lONwGjCRZ/kYPPUpEUlk4nvqMHSFD/4upVx3lEJ0j+3Hn/t+BUquo6SnE85?= =?us-ascii?Q?YZ8fNVPd0Xomof+9C2ZfdrkBRnnJ7BgS4RyXm/LZr66uaTgz8TcT1AtwYHfl?= =?us-ascii?Q?/WN/z70mAdxe0h+foHe4sHjwqI34F1VFNpSI9CIf7Ivcb+oFJQHs6pf0DqYd?= =?us-ascii?Q?5BOfcqklLy+WdHvDTjdNThbO6lPYyuR+HA67o663ci7/Pb3CQ78U3Xu5dooD?= =?us-ascii?Q?FpFA80JNlxtPGgGTmiWDtjr+63ATaP9IDcBxaN9gj2iy499Pg7TGgYjQmvFo?= =?us-ascii?Q?iwo9vP/2LVudn3XcbR1jKVU3lUkAVEW0T961X/UAQ8+pG98Lw5JY66NiAIZy?= =?us-ascii?Q?XaVyVENDYPTCDbWglbRfAX42fz70hRpocBA6js1Rlf6+QBpUbdCBJfjSTouK?= =?us-ascii?Q?K/0dM/xOwnYSe5BCfL2XAV8v5mt1zXmf+FrpYFqi+2YVq6VWcQ=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR06MB4358.namprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(586017)(376014)(366016); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?7NKrffBAnGgkwj3aJbKzMGeSKp3vJBKb6JZQ9E93shFfeuj5hEk1Va96SlgQ?= =?us-ascii?Q?HY8JgYq/7Iqz5DAR8sL/8jqcRWY0MFhkL7PkfHuOv+wgyL7po0yKiScBvevu?= =?us-ascii?Q?xIxRYpByy88gIP/d+nzpDXYJB9RjgIEtkiTKlUqzzKuwO7oRyp6uS3MQGuGG?= =?us-ascii?Q?dJYEIQlCFq+KqLDiIWvLKgzmgW749f05zsU3maqgJ03cJmJmMb+nqt09xzKi?= =?us-ascii?Q?VkEeJOdHGQ2dXdGMl7WX9IL6t5TN+S1zJcMfRgkdDUXx1v7rmFZD4wmKtLP1?= =?us-ascii?Q?UNany/V5UwhPAVFp2uYkzN0MfKLMc3CjwiHxW9gk427ERRm9ydjYc+67Mnfg?= =?us-ascii?Q?ehCiduMUixzr7TBFDkjxn7BNgv52BqdirEcG+95honf0RCcb7/t01nsBoYCl?= =?us-ascii?Q?C2+i6sZJvBaOMBPpOqBCiu3naqprsEE5Og3WVyo+91Ih8740pNK0K/l9wM8T?= =?us-ascii?Q?h55gaoOXqj2Cws8kaKQBL9oeEfi5up7PkTbOrxHp6mlWcupvisztcVUfhuZv?= =?us-ascii?Q?Mo4q6LxubyMYixagPV5H4PHM4xxuTQyGxBC/kiXxMYvxHmfrFF42HWWb3BdK?= =?us-ascii?Q?xul16fIbN012IWKDE90b7s5Lr5G+oOx7A+IKpKHb5eijNzdPxBR+LVseuNJe?= =?us-ascii?Q?0n8wPxf2bRIci26VcP00ufz8gjORNXs7w2tgVyd0l0ZzCefecOvfQ4mEwtog?= =?us-ascii?Q?zLAYMkpN5EZNl8enpbKWwG0HID5ltkZdgq+UZvNOHOqNfwrkQhpd3t9Q6sMl?= =?us-ascii?Q?QvoLkAGPdf7FQ0frbbj0O5KhIWkz86eTioCPUfXEf5vnkJhg4XgWvpVuV0rt?= =?us-ascii?Q?U/Whw5fHVtEAC5UhEOslClyP2CXLhzWK2hvb+4JHZLrJT8TJ1+8KC5Fs3bKL?= =?us-ascii?Q?1XDc1A9sZHN3VKvUi+vKEhgaKonxLtO9GSMSTHGm+P5HFwOB17Vwj75MJSYa?= =?us-ascii?Q?+6XjDebqOtnmrM8GGXyjhdRMsJnEikrCabUK7sLrs+56psep/rB07ISbhpXH?= =?us-ascii?Q?W3QNKP0QaToz9CF8kNRXNGs+Ht0wA7G6Tyh3TkSWwWvQPmc/BDmqECFdZp7Y?= =?us-ascii?Q?Qrr5RvWhzYLPUUQUgiwb4PeLz/a4/267Ol6DXCyXIBn/bfueWeDZdv1HEDCe?= =?us-ascii?Q?lPtLbwE7jQhRqNob5O+5C632I2oxSh9vEwiSa3YWRsbREQbl/J92zDx3fw0K?= =?us-ascii?Q?zSFUik4FCeGfeUO1h/JCY3D2bwkV/F/Yw0kfnoptxl4UK2wOAQ+ja4Hdn+f/?= =?us-ascii?Q?ARLBdxewjh3f9ezIAO1L0tzNWR8/WQaMX9OqxWtpPp6PFmWgTQwmdVZfVtg9?= =?us-ascii?Q?Jt9/Bh+DnJpWnGYvDhBL2PvDCfqCuoaXDQ6fKNx3JC3TVtmKgtERBibD8has?= =?us-ascii?Q?Vy3emM11cHMi8jRITjPwj/Ag5QLp1oiQqAaJUlwDh6aLZGT9U4j/HDlfEi3p?= =?us-ascii?Q?Ppq0iVtHzXfTzfo36ecsw2SgyP891MQQGazcOMJW++vSlEShUhkKTiZkWung?= =?us-ascii?Q?0k8CpJ7vuhbe9qaITPKMZRu9NcgNlSzGETZVW+fvS78U20obO5A2tzzwyFM/?= =?us-ascii?Q?AcRYs1bSyk3OviXLo8MezXJj634HuLV7vy0/2X9j?= X-OriginatorOrg: libvirt.dev X-MS-Exchange-CrossTenant-Network-Message-Id: d0d5d1d4-66fc-4871-05a4-08ddb8b5ca41 X-MS-Exchange-CrossTenant-AuthSource: BYAPR06MB4358.namprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jul 2025 15:41:48.0408 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: ae52e033-9978-468d-bec0-1b48967ffa38 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NTU47ZDpMHPSYtynHZhto0GSeBDkHCbhSqBq8auQq3v8iiL+LDGhy6IWfeKz1/TmX/HgE2ubX6GfBQvAVa82pA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR06MB8197 X-SPAM-LEVEL: Spam detection results: 0 ARC_SIGNED 0.001 Message has a ARC signature ARC_VALID 0.001 Message has a valid ARC signature AWL 0.399 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy FROM_FMBLA_NEWDOM14 0.001 From domain was registered in last 7-14 days KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_NONE -0.0001 Sender listed at https://www.dnswl.org/, no trust SPF_HELO_PASS -0.001 SPF: HELO matches SPF record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH storage] fix #6073: esxi: fix zombie process after storage removal X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" After removing an ESXi storage, a zombie process is generated because the forked FUSE process (esxi-folder-fuse) is not properly reaped. This patch implements a double-fork mechanism to ensure the FUSE process is reparented to init (PID 1), which will properly reap it when it exits. Additionally adds the missing waitpid() call to reap the intermediate child process. Tested on Proxmox VE 8.4.1 with ESXi 8.0U3e storage. Signed-off-by: Stelios Vailakakis --- src/PVE/Storage/ESXiPlugin.pm | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/src/PVE/Storage/ESXiPlugin.pm b/src/PVE/Storage/ESXiPlugin.pm index ab5242d..7c2d16a 100644 --- a/src/PVE/Storage/ESXiPlugin.pm +++ b/src/PVE/Storage/ESXiPlugin.pm @@ -211,7 +211,17 @@ sub esxi_mount : prototype($$$;$) { if (!$pid) { eval { undef $rd; - POSIX::setsid(); + + # Double fork to properly daemonize + POSIX::setsid() or die "failed to create new session: $!\n"; + my $pid2 = fork(); + die "second fork failed: $!\n" if !defined($pid2); + + if ($pid2) { + # First child exits immediately + POSIX::_exit(0); + } + # Second child (grandchild) enters systemd scope PVE::Systemd::enter_systemd_scope( $scope_name_base, "Proxmox VE FUSE mount for ESXi storage $storeid (server $host)", @@ -243,6 +253,8 @@ sub esxi_mount : prototype($$$;$) { } POSIX::_exit(1); } + # Parent wait for first child to exit + waitpid($pid, 0); undef $wr; my $result = do { local $/ = undef; <$rd> }; -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel