From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 9FCDD1FF16B for ; Tue, 1 Jul 2025 17:43:50 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2A532A241; Tue, 1 Jul 2025 17:41:56 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Tue, 1 Jul 2025 17:40:28 +0200 Message-ID: <20250701154117.434512-9-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250701154117.434512-1-f.ebner@proxmox.com> References: <20250701154117.434512-1-f.ebner@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.029 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [zfspoolplugin.pm] Subject: [pve-devel] [PATCH storage v4 08/49] zfs pool plugin: implement method to get qemu blockdevice options X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" ZFS does not have a filesystem_path() method, so the default implementation for qemu_blockdev_options() cannot be re-used. This is most likely, because snapshots are currently not directly accessible via a filesystem path in the Proxmox VE storage layer. Signed-off-by: Fiona Ebner --- Changes in v4: * Assert that volname is not a subvol. src/PVE/Storage/ZFSPoolPlugin.pm | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/src/PVE/Storage/ZFSPoolPlugin.pm b/src/PVE/Storage/ZFSPoolPlugin.pm index 713d26f..86c52ea 100644 --- a/src/PVE/Storage/ZFSPoolPlugin.pm +++ b/src/PVE/Storage/ZFSPoolPlugin.pm @@ -162,6 +162,20 @@ sub path { return ($path, $vmid, $vtype); } +sub qemu_blockdev_options { + my ($class, $scfg, $storeid, $volname) = @_; + + my $format = ($class->parse_volname($volname))[6]; + + die "volume '$volname' not usable as VM image\n" if $format ne 'raw'; + + my ($path) = $class->path($scfg, $volname, $storeid); + + my $blockdev = { driver => 'host_device', filename => $path }; + + return $blockdev; +} + sub zfs_request { my ($class, $scfg, $timeout, $method, @params) = @_; -- 2.47.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel