From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 6A1071FF16B for ; Tue, 1 Jul 2025 17:43:11 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 08D679E76; Tue, 1 Jul 2025 17:41:45 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Tue, 1 Jul 2025 17:41:04 +0200 Message-ID: <20250701154117.434512-45-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250701154117.434512-1-f.ebner@proxmox.com> References: <20250701154117.434512-1-f.ebner@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.029 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH qemu-server v2 44/49] live import/restore: query which node to use for operation X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" In preparation for the switch to -blockdev. Otherwise, there would be an error: > An error occurred during live-restore: VM 103 qmp command > 'block-stream' failed - Permission conflict on node > 'a25d9b2028b5a364dddbb033603b68c': permissions 'write' are both > required by node 'drive-ide0' (uses node > 'a25d9b2028b5a364dddbb033603b68c' as 'file' child) and unshared > by stream job 'restore-drive-ide0' (uses node > 'a25d9b2028b5a364dddbb033603b68c' as 'intermediate node' child). Signed-off-by: Fiona Ebner --- src/PVE/QemuServer.pm | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm index 05c19390..d4154aeb 100644 --- a/src/PVE/QemuServer.pm +++ b/src/PVE/QemuServer.pm @@ -7037,11 +7037,12 @@ sub pbs_live_restore { # removes itself once all backing images vanish with 'auto-remove=on') my $jobs = {}; for my $ds (sort keys %$restored_disks) { + my $node_name = PVE::QemuServer::Blockdev::get_node_name_below_throttle($vmid, $ds); my $job_id = "restore-$ds"; mon_cmd( $vmid, 'block-stream', 'job-id' => $job_id, - device => "$ds", + device => "$node_name", 'auto-dismiss' => JSON::false, ); $jobs->{$job_id} = {}; @@ -7138,11 +7139,13 @@ sub live_import_from_files { # removes itself once all backing images vanish with 'auto-remove=on') my $jobs = {}; for my $ds (sort keys %$live_restore_backing) { + my $node_name = + PVE::QemuServer::Blockdev::get_node_name_below_throttle($vmid, "drive-$ds"); my $job_id = "restore-$ds"; mon_cmd( $vmid, 'block-stream', 'job-id' => $job_id, - device => "drive-$ds", + device => "$node_name", 'auto-dismiss' => JSON::false, ); $jobs->{$job_id} = {}; -- 2.47.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel