From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 133101FF16B for ; Tue, 1 Jul 2025 17:42:02 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B61B39B3F; Tue, 1 Jul 2025 17:41:38 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Tue, 1 Jul 2025 17:40:51 +0200 Message-ID: <20250701154117.434512-32-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250701154117.434512-1-f.ebner@proxmox.com> References: <20250701154117.434512-1-f.ebner@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.029 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH qemu-server v2 31/49] blockdev: make some functions private X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Callers outside the module should only use generate_drive_blockdev() and specific functionality should be controlled via the $options parameter. Signed-off-by: Fiona Ebner --- src/PVE/QemuServer/Blockdev.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/PVE/QemuServer/Blockdev.pm b/src/PVE/QemuServer/Blockdev.pm index 0d5994cb..bedf0584 100644 --- a/src/PVE/QemuServer/Blockdev.pm +++ b/src/PVE/QemuServer/Blockdev.pm @@ -213,7 +213,7 @@ sub generate_throttle_group { }; } -sub generate_blockdev_drive_cache { +my sub generate_blockdev_drive_cache { my ($drive, $scfg) = @_; my $cache_direct = PVE::QemuServer::Drive::drive_uses_cache_direct($drive, $scfg); @@ -223,7 +223,7 @@ sub generate_blockdev_drive_cache { }; } -sub generate_file_blockdev { +my sub generate_file_blockdev { my ($storecfg, $drive, $options) = @_; my $blockdev = {}; @@ -294,7 +294,7 @@ sub generate_file_blockdev { return $blockdev; } -sub generate_format_blockdev { +my sub generate_format_blockdev { my ($storecfg, $drive, $child, $options) = @_; die "generate_format_blockdev called without volid/path\n" if !$drive->{file}; -- 2.47.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel