From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id C07731FF15C for ; Fri, 27 Jun 2025 14:13:11 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0C6DC1397C; Fri, 27 Jun 2025 14:13:46 +0200 (CEST) From: Lukas Wagner To: pve-devel@lists.proxmox.com Date: Fri, 27 Jun 2025 14:13:37 +0200 Message-Id: <20250627121339.182283-1-l.wagner@proxmox.com> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.020 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH proxmox-widget-toolkit 1/3] fix #5588: notification: smtp: fix 'Authenticate' checkbox in Chromium X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" When editing an SMTP endpoint that has no authentication settings, in Chromium-based browsers, the 'Authenticate' checkbox was ticked because of a race condition between the view-model default and the InputPanel logic setting the existing values for the endpoint. Explicitly setting the value in the view model in onSetValues seems to fix this reliably. Tested on: - Firefox 140 - Chromium 137 - Chrome 138 - Gnome Web (Webkit-based) 48 Signed-off-by: Lukas Wagner --- src/panel/SmtpEditPanel.js | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/panel/SmtpEditPanel.js b/src/panel/SmtpEditPanel.js index df6e3b7..fd10b54 100644 --- a/src/panel/SmtpEditPanel.js +++ b/src/panel/SmtpEditPanel.js @@ -196,10 +196,17 @@ Ext.define('Proxmox.panel.SmtpEditPanel', { }, onSetValues: function (values) { + let me = this; + values.authentication = !!values.username; values.enable = !values.disable; delete values.disable; + // Fix race condition in chromium-based browsers. Without this, the + // 'Authenticate' remains ticked (the default value) if loading an + // SMTP target without authentication. + me.getViewModel().set('authentication', values.authentication); + return values; }, }); -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel