From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id B6C2B1FF170 for ; Thu, 26 Jun 2025 09:51:35 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E61A334310; Thu, 26 Jun 2025 09:52:08 +0200 (CEST) From: Christoph Heiss To: pve-devel@lists.proxmox.com Date: Thu, 26 Jun 2025 09:50:46 +0200 Message-ID: <20250626075052.65257-1-c.heiss@proxmox.com> X-Mailer: git-send-email 2.49.0 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.030 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [unconfigured.sh] Subject: [pve-devel] [PATCH installer] unconfigured: add missing [ ] around if clause X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" "-n" would be treated like a command here otherwise. Fixes: dc36013 ("unconfigured: rework stopping systemd-udevd slightly") Signed-off-by: Christoph Heiss --- unconfigured.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/unconfigured.sh b/unconfigured.sh index ddab415..caa08c3 100755 --- a/unconfigured.sh +++ b/unconfigured.sh @@ -81,7 +81,7 @@ real_reboot() { # stop udev (release file handles) udevd_pid="$(pgrep systemd-udevd)" - if -n "$udevd_pid"; then + if [ -n "$udevd_pid" ]; then if kill -s TERM "$udevd_pid"; then if ! waitpid --exited --timeout 5 "$udevd_pid"; then echo "failed to wait for udevd exit - $?" -- 2.49.0 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel