From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 682DC1FF16F for ; Tue, 24 Jun 2025 13:28:01 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E272C3505D; Tue, 24 Jun 2025 13:28:28 +0200 (CEST) From: Lukas Wagner To: pve-devel@lists.proxmox.com Date: Tue, 24 Jun 2025 13:28:16 +0200 Message-Id: <20250624112817.132312-2-l.wagner@proxmox.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250624112817.132312-1-l.wagner@proxmox.com> References: <20250624112817.132312-1-l.wagner@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.020 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager v2 1/2] ui: remove handling of obsolete notification-policy/target settings X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" These were only used in the 'old' revamped notification stack which was briefly available on pvetest. With PVE 9 we can finally get completely rid of these. Signed-off-by: Lukas Wagner --- Notes: Changes since v1: - Rebased onto latest master (PVE 9) www/manager6/dc/Backup.js | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/www/manager6/dc/Backup.js b/www/manager6/dc/Backup.js index 3808aa25..5eb8b5fb 100644 --- a/www/manager6/dc/Backup.js +++ b/www/manager6/dc/Backup.js @@ -37,14 +37,6 @@ Ext.define('PVE.dc.BackupEdit', { delete values.node; } - // Get rid of new-old parameters for notification settings. - // These should only be set for those selected few who ran - // pve-manager from pvetest. - if (!isCreate) { - Proxmox.Utils.assemble_field_data(values, { delete: 'notification-policy' }); - Proxmox.Utils.assemble_field_data(values, { delete: 'notification-target' }); - } - let selMode = values.selMode; delete values.selMode; @@ -158,14 +150,6 @@ Ext.define('PVE.dc.BackupEdit', { let me = this; let viewModel = me.getViewModel(); - // Migrate 'new'-old notification-policy back to old-old mailnotification. - // Only should affect users who used pve-manager from pvetest. This was a remnant of - // notifications before the overhaul. - let policy = data['notification-policy']; - if (policy === 'always' || policy === 'failure') { - data.mailnotification = policy; - } - if (data.exclude) { data.vmid = data.exclude; data.selMode = 'exclude'; -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel