From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
	by lore.proxmox.com (Postfix) with ESMTPS id 24C3B1FF165
	for <inbox@lore.proxmox.com>; Thu,  5 Jun 2025 11:41:52 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 9D46515636;
	Thu,  5 Jun 2025 11:42:09 +0200 (CEST)
From: Shan Shaji <s.shaji@proxmox.com>
To: pve-devel@lists.proxmox.com
Date: Thu,  5 Jun 2025 11:41:17 +0200
Message-Id: <20250605094118.93815-2-s.shaji@proxmox.com>
X-Mailer: git-send-email 2.39.5
In-Reply-To: <20250605094118.93815-1-s.shaji@proxmox.com>
References: <20250605094118.93815-1-s.shaji@proxmox.com>
MIME-Version: 1.0
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.346 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: [pve-devel] [PATCH pve_flutter_frontend v3 1/1] fix: resources: add
 filter option for `paused` guest status
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>

In the resources tab there were no option to filter the guest
when the status is `paused`. To fix the issue, add new `paused`
filter option under status section of the drawer.

Additionaly rather than copy pasting the
`_ProxmoxResourceFilterLisTile`, add a for loop that will
iterate over all the statuses.

Signed-off-by: Shan Shaji <s.shaji@proxmox.com>
---

 changes since v2:
 * rebase the changes with master. 
 * fix commit message.
 
 .../pve_mobile_resource_filter_sheet.dart     | 40 +++++++------------
 1 file changed, 15 insertions(+), 25 deletions(-)

diff --git a/lib/widgets/pve_mobile_resource_filter_sheet.dart b/lib/widgets/pve_mobile_resource_filter_sheet.dart
index cee3a49..34e169b 100644
--- a/lib/widgets/pve_mobile_resource_filter_sheet.dart
+++ b/lib/widgets/pve_mobile_resource_filter_sheet.dart
@@ -84,34 +84,24 @@ class PveMobileResourceFilterSheet extends StatelessWidget {
               _PveFilterSheetSection(
                 sectionTitle: 'Status',
                 items: [
-                  _ProxmoxResourceFilterListTile(
-                    title: 'Online',
-                    value: state.statusFilter
-                        .contains(PveResourceStatusType.running),
-                    onChanged: (v) => rBloc.events.add(
-                      FilterResources(
-                        statusFilter: _addOrRemove(
-                          v!,
-                          PveResourceStatusType.running,
-                          state.statusFilter,
-                        ),
-                      ),
-                    ),
-                  ),
-                  _ProxmoxResourceFilterListTile(
-                    title: 'Offline',
-                    value: state.statusFilter
-                        .contains(PveResourceStatusType.stopped),
-                    onChanged: (v) => rBloc.events.add(
-                      FilterResources(
-                        statusFilter: _addOrRemove(
-                          v!,
-                          PveResourceStatusType.stopped,
-                          state.statusFilter,
+                  for (var filterItem in [
+                    (title: 'Online', type: PveResourceStatusType.running),
+                    (title: 'Offline', type: PveResourceStatusType.stopped),
+                    (title: 'Paused', type: PveResourceStatusType.paused)
+                  ])
+                    _ProxmoxResourceFilterListTile(
+                      title: filterItem.title,
+                      value: state.statusFilter.contains(filterItem.type),
+                      onChanged: (v) => rBloc.events.add(
+                        FilterResources(
+                          statusFilter: _addOrRemove(
+                            v!,
+                            filterItem.type,
+                            state.statusFilter,
+                          ),
                         ),
                       ),
                     ),
-                  ),
                 ],
               )
             ],
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel