From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	by lore.proxmox.com (Postfix) with ESMTPS id 0BEB11FF15E
	for <inbox@lore.proxmox.com>; Tue,  3 Jun 2025 15:09:57 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id CB41A19B84;
	Tue,  3 Jun 2025 15:10:12 +0200 (CEST)
From: Christian Ebner <c.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Date: Tue,  3 Jun 2025 15:09:16 +0200
Message-Id: <20250603130916.310066-4-c.ebner@proxmox.com>
X-Mailer: git-send-email 2.39.5
In-Reply-To: <20250603130916.310066-1-c.ebner@proxmox.com>
References: <20250603130916.310066-1-c.ebner@proxmox.com>
MIME-Version: 1.0
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.034 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: [pve-devel] [PATCH manager 2/2] ui: switch default and extend
 options for PBS change detection mode
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>

Switch the current implied default `legacy` option with the new
default value `metadata`, as set by vzdump.

Further, allow to switch back to the previous default by adding the
`legacy` option and keep the `metadata` mode as separate, dedicated
option so pre-exiting backup job configurations still work as
expected.

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
NOTE: Assumes repo pre-formatted with proxmox-biome to apply

 www/manager6/form/PbsChangeDetectionModeSelector.js | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/www/manager6/form/PbsChangeDetectionModeSelector.js b/www/manager6/form/PbsChangeDetectionModeSelector.js
index 6e55aabd..e5a6c20f 100644
--- a/www/manager6/form/PbsChangeDetectionModeSelector.js
+++ b/www/manager6/form/PbsChangeDetectionModeSelector.js
@@ -3,8 +3,9 @@ Ext.define('PVE.form.PBSChangeDetectionModeSelector', {
     alias: ['widget.pbsChangeDetectionModeSelector'],
     deleteEmpty: true,
     comboItems: [
-        ['__default__', 'Default'],
+        ['__default__', 'Default (Metadata)'],
         ['data', 'Data'],
         ['metadata', 'Metadata'],
+        ['legacy', 'Legacy'],
     ],
 });
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel