From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 4867D1FF15E for <inbox@lore.proxmox.com>; Tue, 3 Jun 2025 15:09:24 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1BE4C19A35; Tue, 3 Jun 2025 15:09:43 +0200 (CEST) From: Christian Ebner <c.ebner@proxmox.com> To: pve-devel@lists.proxmox.com Date: Tue, 3 Jun 2025 15:09:14 +0200 Message-Id: <20250603130916.310066-2-c.ebner@proxmox.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250603130916.310066-1-c.ebner@proxmox.com> References: <20250603130916.310066-1-c.ebner@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.034 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH container 1/1] vzdump: switch default PBS change detection mode to `metadata` X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> Since commit 58839940 ("vzdump: conditionally set PBS change detection mode option") it is possible to perform container backups with Proxmox Backup Server as target using additional `data` and `metadata` modes provided by the Proxmox Backup client. While the `metadata` mode was introduced to speed up file level backups [0], the `legacy` mode was kept as default to not unexpectedly change the mode for container backups. Switch the default mode to `metadata` for the upcoming Proxmox Virtual Environment 9 release. By explicitly setting the mode, this is independent from the PBS client's default. [0] https://bugzilla.proxmox.com/show_bug.cgi?id=3174 Signed-off-by: Christian Ebner <c.ebner@proxmox.com> --- NOTE: Assumes repo pre-formatted with proxmox-perltidy to apply src/PVE/VZDump/LXC.pm | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/PVE/VZDump/LXC.pm b/src/PVE/VZDump/LXC.pm index c10a4c9..84a6e02 100644 --- a/src/PVE/VZDump/LXC.pm +++ b/src/PVE/VZDump/LXC.pm @@ -465,8 +465,10 @@ sub archive { push @$param, '--backup-type', 'ct'; push @$param, '--backup-id', $vmid; push @$param, '--backup-time', $task->{backup_time}; - push @$param, '--change-detection-mode', $opts->{"pbs-change-detection-mode"} - if $opts->{"pbs-change-detection-mode"}; + push @$param, '--change-detection-mode', + $opts->{"pbs-change-detection-mode"} + ? $opts->{"pbs-change-detection-mode"} + : 'metadata'; if (my $entries_max = $opts->{"performance"}->{"pbs-entries-max"}) { push $param->@*, '--entries-max', $entries_max; -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel