From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
by lore.proxmox.com (Postfix) with ESMTPS id 8E6DE1FF15E
for <inbox@lore.proxmox.com>; Tue, 3 Jun 2025 14:20:38 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id CB88018728;
Tue, 3 Jun 2025 14:20:53 +0200 (CEST)
From: Shan Shaji <s.shaji@proxmox.com>
To: pve-devel@lists.proxmox.com
Date: Tue, 3 Jun 2025 14:20:35 +0200
Message-Id: <20250603122037.158232-1-s.shaji@proxmox.com>
X-Mailer: git-send-email 2.39.5
MIME-Version: 1.0
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.373 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
information. [proxmox.com]
Subject: [pve-devel] [PATCH proxmox{_login_manager,
_dart_api_client} v3 0/2] fix #6409: login manager doesn't
pre-selects default authentication realm
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
When the `default` property was selected inside the realm of the web UI,
the app's login page was not showing the default realm instead,
it was always showing PAM.
To reproduce, follow the following steps:
on the web UI go to Datacenter -> Realms and edit another realm than
PAM, like PVE. There you can tick the "Default" checkbox. Now go to
the app and try adding the domain, `PAM` will be selected as default.
This patch series fixes the issue by adding the `default` property
to the `PveAccessDomainModel` and implementing the necessary
check in the `_getAccessDomains` function.
History
==========
v2: https://lore.proxmox.com/pve-devel/20250526154137.116322-1-s.shaji@proxmox.com/T/#t
changes since v2:
* removed "This commit" string from commit messages.
* fixed `StateError` in `singleWhere` function which can happen
when both conditions are true.
* If a realm is already saved then that selection will have priority.
proxmox_login_manager:
Shan Shaji (1):
fix #6409: add `isDefaultRealm` check to pre-select realm in login
form
lib/proxmox_login_form.dart | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
proxmox_dart_api_client:
Shan Shaji (1):
fix #6409: add `default` property to `PveAccessDomainModel`
lib/src/models/pve_access_domain_model.dart | 5 +++++
1 file changed, 5 insertions(+)
Summary over all repositories:
2 files changed, 8 insertions(+), 1 deletions(-)
--
Generated by git-murpp 0.8.1
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel