From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 2EAC01FF18A for <inbox@lore.proxmox.com>; Mon, 26 May 2025 16:20:04 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 975C034463; Mon, 26 May 2025 16:20:16 +0200 (CEST) From: Fiona Ebner <f.ebner@proxmox.com> To: pve-devel@lists.proxmox.com Date: Mon, 26 May 2025 16:19:41 +0200 Message-Id: <20250526141941.1654201-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.033 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH v2 manager] api: create pool: force first character to be a letter for new pools X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> Currently, the first character can also be a digit, '.', '-', or '_'. Almost all other configuration IDs in Proxmox VE require starting with a letter, so force this for new pool names too. A pool with ID '0' can be added, but not parsed, because it will evaluate to false in PVE/AccessControl.pm's parse_user_config(): > if (!verify_poolname($pool, 1)) { > warn "user config - ignore pool '$pool' - invalid characters in pool name\n"; > next; > } It's likely that it would cause other issues as well if properly handled there. Signed-off-by: Fiona Ebner <f.ebner@proxmox.com> --- Breaking change intended for Proxmox VE 9! Changes in v2: * Different approach, force new pools to start with a letter. PVE/API2/Pool.pm | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/PVE/API2/Pool.pm b/PVE/API2/Pool.pm index 54e74455..4b5e534c 100644 --- a/PVE/API2/Pool.pm +++ b/PVE/API2/Pool.pm @@ -184,10 +184,13 @@ __PACKAGE__->register_method ({ my $pool = $param->{poolid}; die "pool '$pool' already exists\n" if $usercfg->{pools}->{$pool}; - if ($pool =~ m!^(.*)/[^/]+$!) { - my $parent = $1; + if ($pool =~ m!^(.*)/([^/]+)$!) { + my ($parent, $leaf) = ($1, $2); die "parent '$parent' of pool '$pool' does not exist\n" if !defined($usercfg->{pools}->{$parent}); + die "pool name must start with a letter\n" if $leaf !~ m!^[A-Za-z]!; + } else { + die "pool name must start with a letter\n" if $pool !~ m!^[A-Za-z]!; } $usercfg->{pools}->{$pool} = { -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel