From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 1B0C71FF164 for <inbox@lore.proxmox.com>; Fri, 23 May 2025 15:33:10 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EEE361BD4E; Fri, 23 May 2025 15:32:36 +0200 (CEST) From: Fiona Ebner <f.ebner@proxmox.com> To: pve-devel@lists.proxmox.com Date: Fri, 23 May 2025 15:31:56 +0200 Message-Id: <20250523133156.617227-11-f.ebner@proxmox.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250523133156.617227-1-f.ebner@proxmox.com> References: <20250523133156.617227-1-f.ebner@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.033 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_SHORT 0.001 Use of a URL Shortener for very short URL SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [RFC v2 storage 10/10] plugin api: bump api version and age X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> Introduce qemu_blockdev_options() plugin method. In terms of the plugin API only, adding the qemu_blockdev_options() method is a fully backwards-compatible change. When qemu-server will switch to '-blockdev' however, plugins where the default implemenation is not sufficient, will not be usable for virtual machines anymore. Therefore, this is intended for the next major release, Proxmox VE 9. Signed-off-by: Fiona Ebner <f.ebner@proxmox.com> --- New in v2. ApiChangeLog | 13 +++++++++++++ src/PVE/Storage.pm | 4 ++-- 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/ApiChangeLog b/ApiChangeLog index 987da54..062e75b 100644 --- a/ApiChangeLog +++ b/ApiChangeLog @@ -6,6 +6,19 @@ without breaking anything unaware of it.) Future changes should be documented in here. +## Version 12: + +* Introduce `qemu_blockdev_options()` plugin method + + Proxmox VE will switch to the more modern QEMU command line option `-blockdev` replacing `-drive`. + With `-drive`, it was enough to specify a path, where special protocol paths like `iscsi://` were + also supported. With `-blockdev`, the data is more structured, a driver needs to be specified + alongside the path to an image and each driver supports driver-specific options. Most storage + plugins should be fine using driver `host_device` in case of a block device and `file` in case of + a file and no special options, see the default implemenation of the base plugin. Implement this + this method for Proxmox VE 9. For available drivers and driver-specific options, see: + https://qemu.readthedocs.io/en/master/interop/qemu-qmp-ref.html#object-QMP-block-core.BlockdevOptions + ## Version 11: * Allow declaring storage features via plugin data diff --git a/src/PVE/Storage.pm b/src/PVE/Storage.pm index 3b0f07e..39bb492 100755 --- a/src/PVE/Storage.pm +++ b/src/PVE/Storage.pm @@ -42,11 +42,11 @@ use PVE::Storage::BTRFSPlugin; use PVE::Storage::ESXiPlugin; # Storage API version. Increment it on changes in storage API interface. -use constant APIVER => 11; +use constant APIVER => 12; # Age is the number of versions we're backward compatible with. # This is like having 'current=APIVER' and age='APIAGE' in libtool, # see https://www.gnu.org/software/libtool/manual/html_node/Libtool-versioning.html -use constant APIAGE => 2; +use constant APIAGE => 3; our $KNOWN_EXPORT_FORMATS = ['raw+size', 'tar+size', 'qcow2+size', 'vmdk+size', 'zfs', 'btrfs']; -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel