From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id E89591FF164 for <inbox@lore.proxmox.com>; Fri, 23 May 2025 15:32:52 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D83701BC9E; Fri, 23 May 2025 15:32:32 +0200 (CEST) From: Fiona Ebner <f.ebner@proxmox.com> To: pve-devel@lists.proxmox.com Date: Fri, 23 May 2025 15:31:46 +0200 Message-Id: <20250523133156.617227-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.034 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [zfspoolplugin.pm, storage.pm, iscsidirectplugin.pm, plugin.pm, rbdplugin.pm, zfsplugin.pm] Subject: [pve-devel] [RFC v2 qemu/storage 00/10] storage plugin method to get qemu blockdevice options for volume X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> Changes in v2: * Patch QEMU to support both keyring and rbd_cache_policy settings, it is much cleaner than generate per-volume (or technically would even be per-instance, as a volume could be re-used) temporary ceph.conf files. For keyring, we could also make sure to write the path to every storage's ceph.conf in pve8to9 and require it going forward, but supporting the option in QEMU seems to be the simplest. The rbd_cache_policy is truly a per-volume setting in Proxmox VE, which is specifically changed for EFI disks, so ceph.conf is just not the right place for that setting. * Add a special 'hints' option to indicate when it's an EFI disk, so the RBD plugin can set the policy. * Drop $snapshot parameter, currently there is no need to attach snapshots via -blockdev. They would need to be attached read-only too to not fail and this can always be added later. When using -drive, storage plugins currently give us a path that QEMU understands, some using special protocols such as 'iscsi://'. We'd like to switch to using the more modern -blockdev for PVE 9. The plan is to have the storage plugins return the very basic information required to access the image, and qemu-server can then add other settings like cache, aio, etc. on top. In fact, pretty similar to what we have now for -drive, just with a structured hash rather than a string. This is also a prerequisite for qemu-storage-deamon, that would be useful for TPM-as-qcow2 exported via NBD or FUSE or external backup provider restore providing an NBD export for the provider to write to. QEMU patches submitted upstream here: https://lore.kernel.org/qemu-devel/20250515112908.383693-1-f.ebner@proxmox.com/ qemu: Fiona Ebner (2): block/rbd: support selected key-value-pairs via QAPI block/rbd: support keyring option via QAPI block/rbd.c | 81 ++++++++++++++++++++++++++++++++++++++++++++ qapi/block-core.json | 40 ++++++++++++++++++++++ 2 files changed, 121 insertions(+) storage: Fiona Ebner (8): plugin: add method to get qemu blockdevice options for volume iscsi direct plugin: implement method to get qemu blockdevice options zfs iscsi plugin: implement new method to get qemu blockdevice options zfs pool plugin: implement method to get qemu blockdevice options rbd plugin: implement new method to get qemu blockdevice options plugin: qemu block device: add hints option and EFI disk hint plugin: qemu block device: add support for snapshot option plugin api: bump api version and age ApiChangeLog | 13 ++++ src/PVE/Storage.pm | 21 ++++++- src/PVE/Storage/ISCSIDirectPlugin.pm | 17 +++++ src/PVE/Storage/Plugin.pm | 93 ++++++++++++++++++++++++++++ src/PVE/Storage/RBDPlugin.pm | 49 +++++++++++++++ src/PVE/Storage/ZFSPlugin.pm | 19 ++++++ src/PVE/Storage/ZFSPoolPlugin.pm | 12 ++++ 7 files changed, 222 insertions(+), 2 deletions(-) -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel