From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 73DE71FF165 for ; Thu, 22 May 2025 18:23:28 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5E650B330; Thu, 22 May 2025 18:18:36 +0200 (CEST) From: Stefan Hanreich To: pve-devel@lists.proxmox.com Date: Thu, 22 May 2025 18:17:11 +0200 Message-Id: <20250522161731.537011-56-s.hanreich@proxmox.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250522161731.537011-1-s.hanreich@proxmox.com> References: <20250522161731.537011-1-s.hanreich@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.222 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Subject: [pve-devel] [PATCH proxmox-widget-toolkit v3 1/1] network selector: add type parameter X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" The network endpoint of the PVE API allows selecting interfaces by type, but the network selector widget currently does not support passing the type to the API call. This is required for the SDN fabrics, which introduced a new special type to this endpoint that additionally selects all SDN interfaces. This can then be used to make SDN fabrics show up in the Migration Settings dialog or in the Ceph Installation Wizards. Signed-off-by: Stefan Hanreich --- src/form/NetworkSelector.js | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/src/form/NetworkSelector.js b/src/form/NetworkSelector.js index caa7b7e..8fa3d60 100644 --- a/src/form/NetworkSelector.js +++ b/src/form/NetworkSelector.js @@ -8,7 +8,10 @@ Ext.define('Proxmox.form.NetworkSelectorController', { if (!view.nodename) { throw "missing custom view config: nodename"; } - view.getStore().getProxy().setUrl('/api2/json/nodes/'+ view.nodename + '/network'); + view + .getStore() + .getProxy() + .setUrl(`/api2/json/nodes/${view.nodename}/network${view.getQueryString()}`); }, }); @@ -33,6 +36,11 @@ Ext.define('Proxmox.form.NetworkSelector', { controller: 'proxmoxNetworkSelectorController', + type: undefined, + getQueryString: function() { + return this.type ? `?type=${this.type}` : ''; + }, + nodename: 'localhost', setNodename: function(nodename) { this.nodename = nodename; @@ -41,7 +49,9 @@ Ext.define('Proxmox.form.NetworkSelector', { // because of manual local copy of data for ip4/6 this.getPicker().refresh(); if (networkSelectorStore && typeof networkSelectorStore.getProxy === 'function') { - networkSelectorStore.getProxy().setUrl('/api2/json/nodes/'+ nodename + '/network'); + networkSelectorStore + .getProxy() + .setUrl(`/api2/json/nodes/${nodename}/network${this.getQueryString()}`); networkSelectorStore.load(); } }, -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel