From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 3EF401FF165 for <inbox@lore.proxmox.com>; Thu, 22 May 2025 09:58:33 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 685AC2F816; Thu, 22 May 2025 09:58:33 +0200 (CEST) From: Shan Shaji <s.shaji@proxmox.com> To: pve-devel@lists.proxmox.com Date: Thu, 22 May 2025 09:58:12 +0200 Message-Id: <20250522075812.18467-1-s.shaji@proxmox.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.363 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [flutter.dev] Subject: [pve-devel] [PATCH proxmox_login_manager v2] refactor: rename `MaterialState` to `WidgetState` X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> This commit applys the `dart fix` command to fix all the dart analysis issues associated with renaming `MaterialState` to `WidgetState`. According to the flutter official docs [0] the `MaterialState` and it's related APIs have been moved out of the material library and renamed to `WidgetState`. The behaviour of the two are the same. - [0] https://docs.flutter.dev/release/breaking-changes/material-state Signed-off-by: Shan Shaji <s.shaji@proxmox.com> --- changes since v1: * Removed all changes that were not part of `dart fix` lib/proxmox_login_form.dart | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/lib/proxmox_login_form.dart b/lib/proxmox_login_form.dart index 735bd42..312ffb6 100644 --- a/lib/proxmox_login_form.dart +++ b/lib/proxmox_login_form.dart @@ -257,46 +257,46 @@ class _ProxmoxLoginPageState extends State<ProxmoxLoginPage> { secondary: ProxmoxColors.orange, onSecondary: ProxmoxColors.supportGrey), checkboxTheme: CheckboxThemeData( - fillColor: MaterialStateProperty.resolveWith<Color?>( - (Set<MaterialState> states) { - if (states.contains(MaterialState.disabled)) { + fillColor: WidgetStateProperty.resolveWith<Color?>( + (Set<WidgetState> states) { + if (states.contains(WidgetState.disabled)) { return null; } - if (states.contains(MaterialState.selected)) { + if (states.contains(WidgetState.selected)) { return ProxmoxColors.orange; } return null; }), ), radioTheme: RadioThemeData( - fillColor: MaterialStateProperty.resolveWith<Color?>( - (Set<MaterialState> states) { - if (states.contains(MaterialState.disabled)) { + fillColor: WidgetStateProperty.resolveWith<Color?>( + (Set<WidgetState> states) { + if (states.contains(WidgetState.disabled)) { return null; } - if (states.contains(MaterialState.selected)) { + if (states.contains(WidgetState.selected)) { return ProxmoxColors.orange; } return null; }), ), switchTheme: SwitchThemeData( - thumbColor: MaterialStateProperty.resolveWith<Color?>( - (Set<MaterialState> states) { - if (states.contains(MaterialState.disabled)) { + thumbColor: WidgetStateProperty.resolveWith<Color?>( + (Set<WidgetState> states) { + if (states.contains(WidgetState.disabled)) { return null; } - if (states.contains(MaterialState.selected)) { + if (states.contains(WidgetState.selected)) { return ProxmoxColors.orange; } return null; }), - trackColor: MaterialStateProperty.resolveWith<Color?>( - (Set<MaterialState> states) { - if (states.contains(MaterialState.disabled)) { + trackColor: WidgetStateProperty.resolveWith<Color?>( + (Set<WidgetState> states) { + if (states.contains(WidgetState.disabled)) { return null; } - if (states.contains(MaterialState.selected)) { + if (states.contains(WidgetState.selected)) { return ProxmoxColors.orange; } return null; -- 2.39.5 (Apple Git-154) _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel