From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
by lore.proxmox.com (Postfix) with ESMTPS id CA7181FF170
for <inbox@lore.proxmox.com>; Thu, 15 May 2025 10:01:55 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id A18531C162;
Thu, 15 May 2025 10:02:17 +0200 (CEST)
From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Date: Thu, 15 May 2025 10:02:14 +0200
Message-Id: <20250515080214.734035-1-d.csapak@proxmox.com>
X-Mailer: git-send-email 2.39.5
MIME-Version: 1.0
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.022 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: [pve-devel] [PATCH widget-toolkit v2] fix #6312: limit consent
window to viewport size
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
The consent window will try to size itself according to the max/min
constraints set, but those might be too large for some viewport sizes.
Since it's not possible to set those to relative viewport sizes (ExtJS
does it's own layout, so we can't use CSS), we have to save the original
size and on resize of the viewport limit ourselves to that (minus 10 px
safety margin).
Even with that the window will adhere to the set constraint sizes,
but it should be viewable with any sensible display/viewport size.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
changes from v1:
* use afterComponentLayout instead of aferrender event, since the full
layouting including sizes + constraints is done afterwards
* don't manually apply/check constraints, since that is done
by the layouting already
* adapt commit message
src/window/ConsentModal.js | 30 ++++++++++++++++++++++++++++++
1 file changed, 30 insertions(+)
diff --git a/src/window/ConsentModal.js b/src/window/ConsentModal.js
index 2826899..6e2f505 100644
--- a/src/window/ConsentModal.js
+++ b/src/window/ConsentModal.js
@@ -32,5 +32,35 @@ Ext.define('Proxmox.window.ConsentModal', {
text: gettext('OK'),
},
],
+
+ onResize: function() {
+ let me = this;
+ let viewportSize = Ext.getBody().getViewSize();
+
+ let originalSize = me.originalSize ?? me.getSize();
+ // limit to viewport size - 10px for safety
+ let newSize = {
+ width: Math.min(originalSize.width, viewportSize.width - 10),
+ height: Math.min(originalSize.height, viewportSize.height - 10),
+ };
+
+ me.setSize(newSize);
+ me.alignTo(Ext.getBody(), 'c-c');
+ },
+
+ afterComponentLayout: function(width, height) {
+ let me = this;
+ me.originalSize ??= { width, height };
+ },
+
+ listeners: {
+ resize: 'onResize',
+ },
+
+ initComponent: function() {
+ let me = this;
+ me.callParent();
+ me.mon(Ext.getBody(), 'resize', me.onResize, me);
+ },
});
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel