From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	by lore.proxmox.com (Postfix) with ESMTPS id A870D1FF165
	for <inbox@lore.proxmox.com>; Thu, 24 Apr 2025 18:25:36 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 384CAB19F;
	Thu, 24 Apr 2025 18:25:42 +0200 (CEST)
From: Shan Shaji <s.shaji@proxmox.com>
To: pve-devel@lists.proxmox.com
Date: Thu, 24 Apr 2025 18:25:19 +0200
Message-Id: <20250424162519.259066-1-s.shaji@proxmox.com>
X-Mailer: git-send-email 2.39.5
MIME-Version: 1.0
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.150 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery
 methods
 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_NONE                0.001 SPF: sender does not publish an SPF Record
Subject: [pve-devel] [PATCH pve_flutter_frontend] widgets: migrate from
 ButtonBar to OverflowBar
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Cc: Shan Shaji <s.shaji@proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>

The `ButtonBar` widget has been deprecated as of Flutter
v3.21.0-10.0.pre. This patch replaces instance of `ButtonBar`
with `OverflowBar`.

Signed-off-by: Shan Shaji <s.shaji@proxmox.com>
---
 .../pve_task_log_expansiontile_widget.dart    | 40 +++++++++++--------
 1 file changed, 23 insertions(+), 17 deletions(-)

diff --git a/lib/widgets/pve_task_log_expansiontile_widget.dart b/lib/widgets/pve_task_log_expansiontile_widget.dart
index 6491b6b..ed4481b 100644
--- a/lib/widgets/pve_task_log_expansiontile_widget.dart
+++ b/lib/widgets/pve_task_log_expansiontile_widget.dart
@@ -119,24 +119,30 @@ class _PveTaskExpansionTileState extends State<PveTaskExpansionTile> {
           dense: true,
           subtitle: const Text('Shortlog'),
         ),
-        ButtonBar(
-          children: <Widget>[
-            if (widget.showMorePage != null)
+        Padding(
+          padding: const EdgeInsets.only(right: 8, bottom: 8),
+          child: OverflowBar(
+            alignment: MainAxisAlignment.end,
+            spacing: 8,
+            overflowAlignment: OverflowBarAlignment.end,
+            children: <Widget>[
+              if (widget.showMorePage != null)
+                OutlinedButton.icon(
+                  onPressed: () => Navigator.of(context).push(
+                      _createTaskLogRoute(taskLogBloc, widget.showMorePage)),
+                  icon: const Icon(Icons.format_list_bulleted),
+                  label: const Text('More Tasks'),
+                ),
               OutlinedButton.icon(
-                onPressed: () => Navigator.of(context).push(
-                    _createTaskLogRoute(taskLogBloc, widget.showMorePage)),
-                icon: const Icon(Icons.format_list_bulleted),
-                label: const Text('More Tasks'),
-              ),
-            OutlinedButton.icon(
-              onPressed: () => showTaskLogBottomSheet(context,
-                  taskLogBloc.apiClient, widget.task.node, widget.task.upid),
-              icon: const Icon(Icons.article),
-              label: const Text(
-                'Full Log',
-              ),
-            )
-          ],
+                onPressed: () => showTaskLogBottomSheet(context,
+                    taskLogBloc.apiClient, widget.task.node, widget.task.upid),
+                icon: const Icon(Icons.article),
+                label: const Text(
+                  'Full Log',
+                ),
+              )
+            ],
+          ),
         )
       ],
     );
-- 
2.39.5


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel