From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 212A41FF165 for ; Thu, 24 Apr 2025 15:44:21 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 047888739; Thu, 24 Apr 2025 15:44:27 +0200 (CEST) From: Maximiliano Sandoval To: pve-devel@lists.proxmox.com Date: Thu, 24 Apr 2025 15:44:23 +0200 Message-Id: <20250424134423.364697-1-m.sandoval@proxmox.com> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.096 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager] ui: login: display error messages when logging X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" This allows to distinguish, for example, the following three cases: - The pvedaemon service is not responding (595) - The pveproxy service is not responding (no error status code) - The authentication credentials are not correct (401) Since different combinations of wrong password and/or wrong user all report the same error message: "authentication failure (401)" this does not leak login information. Another consideration is that the code `resp.status` does not match the HTTP code seen in the API (a failed authentication has a return code 200 from the point of view of the browser) and its information is lost without this change. Signed-off-by: Maximiliano Sandoval --- www/manager6/window/LoginWindow.js | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/www/manager6/window/LoginWindow.js b/www/manager6/window/LoginWindow.js index a1ba3cdb..066c053a 100644 --- a/www/manager6/window/LoginWindow.js +++ b/www/manager6/window/LoginWindow.js @@ -157,6 +157,14 @@ Ext.define('PVE.window.LoginWindow', { }; let emsg = gettext("Login failed. Please try again"); + if (resp.status) { + emsg = Ext.String.format( + "{0}
{1}
{2}", + gettext("Login failed:"), + resp.htmlStatus, + gettext("Please try again"), + ); + } if (resp.failureType === "connect") { emsg = gettext("Connection failure. Network error or Proxmox VE services not running?"); -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel