From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 3E0D91FF16F for ; Tue, 15 Apr 2025 15:53:35 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 96C6C9DB7; Tue, 15 Apr 2025 15:51:59 +0200 (CEST) From: Daniel Kral To: pve-devel@lists.proxmox.com Date: Tue, 15 Apr 2025 15:50:44 +0200 Message-Id: <20250415135045.255272-27-d.kral@proxmox.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250415135045.255272-1-d.kral@proxmox.com> References: <20250415135045.255272-1-d.kral@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.013 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH container v3 10/11] api: update_vm: use volume content type assertion helpers X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Make use of the newly introduced content type assertion helpers at verifying the added and/or changed container config values, which is called e.g. in the API handler for updating the container config. Signed-off-by: Daniel Kral --- changes since v2: * rename helper from *_supported to *_available src/PVE/LXC/Config.pm | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm index 0740e8c..cedf061 100644 --- a/src/PVE/LXC/Config.pm +++ b/src/PVE/LXC/Config.pm @@ -1176,9 +1176,7 @@ sub update_pct_config { my $check_content_type = sub { my ($mp) = @_; my $sid = PVE::Storage::parse_volume_id($mp->{volume}); - my $storage_config = PVE::Storage::storage_config($storage_cfg, $sid); - die "storage '$sid' does not allow content type 'rootdir' (Container)\n" - if !$storage_config->{content}->{rootdir}; + PVE::Storage::assert_content_type_available($storage_cfg, $sid, 'rootdir'); }; foreach my $opt (sort keys %$param) { # add/change -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel