From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
by lore.proxmox.com (Postfix) with ESMTPS id 470FF1FF164
for <inbox@lore.proxmox.com>; Fri, 11 Apr 2025 12:01:36 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id C92B9E5C4;
Fri, 11 Apr 2025 12:01:30 +0200 (CEST)
From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Date: Fri, 11 Apr 2025 12:01:27 +0200
Message-Id: <20250411100127.3409617-1-d.csapak@proxmox.com>
X-Mailer: git-send-email 2.39.5
MIME-Version: 1.0
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.022 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: [pve-devel] [PATCH widget-toolkit] fix #6312: limit consent window
to viewport size
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
The consent window will try to size itself according to the max/min
constraints set, but those might be too large for some viewport sizes.
Since it's not possible to set those to relative viewport sizes (ExtJS
does it's own layout, so we can't use CSS), we have to save the original
size (while factoring in the constraints) and on resize of the viewport
(or the window) limit ourselves to that (minus 10 px safety margin).
Even with that the window will adhere to the set constraint sizes,
but it should be viewable with any sensible display/viewport size.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
we could think about implementing such a limit for all of our windows
in e.g. Toolkit.js, but I'm not sure if that's wise, since not all
windows are as flexible with the size as the consent window.
src/window/ConsentModal.js | 33 +++++++++++++++++++++++++++++++++
1 file changed, 33 insertions(+)
diff --git a/src/window/ConsentModal.js b/src/window/ConsentModal.js
index 2826899..184933d 100644
--- a/src/window/ConsentModal.js
+++ b/src/window/ConsentModal.js
@@ -32,5 +32,38 @@ Ext.define('Proxmox.window.ConsentModal', {
text: gettext('OK'),
},
],
+
+ onResize: function() {
+ let me = this;
+ let viewportSize = Ext.getBody().getViewSize();
+
+ // limit to viewport size - 10px for safety
+ let newSize = {
+ width: Math.min(me.originalSize.width, viewportSize.width - 10),
+ height: Math.min(me.originalSize.height, viewportSize.height - 10),
+ };
+
+ me.setSize(newSize);
+ me.alignTo(Ext.getBody(), 'c-c');
+ },
+
+ listeners: {
+ resize: 'onResize',
+ afterRender: function(win) {
+ let size = win.getSize();
+ // save the original size, but factor in the constraints, since
+ // those will be applied by extjs later
+ win.originalSize = {
+ width: Math.min(Math.max(size.width, win.minWidth), win.maxWidth),
+ height: Math.min(Math.max(size.height, win.minHeight), win.maxHeight),
+ };
+ },
+ },
+
+ initComponent: function() {
+ let me = this;
+ me.callParent();
+ me.mon(Ext.getBody(), 'resize', me.onResize, me);
+ },
});
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel