From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
by lore.proxmox.com (Postfix) with ESMTPS id 51E2B1FF165
for <inbox@lore.proxmox.com>; Thu, 10 Apr 2025 10:34:12 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 83D5231AA5;
Thu, 10 Apr 2025 10:34:06 +0200 (CEST)
From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Date: Thu, 10 Apr 2025 10:33:33 +0200
Message-Id: <20250410083333.1781596-1-d.csapak@proxmox.com>
X-Mailer: git-send-email 2.39.5
MIME-Version: 1.0
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.022 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: [pve-devel] [PATCH manager v2] ui: backup: hide change mode
detection for vms and non-pbs storage
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
Since it does not do anything for non-pbs storages and vms, this is only
distracting in these cases, so hide the selector + tooltip help icon.
Refactor the help icon into a variable, so we can more easily
disable/hide it.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
replacement for:
https://lore.proxmox.com/pve-devel/20250410080821.1297854-1-d.csapak@proxmox.com/
changes from v1:
* hide the selctor and tooltip completely instead of disabling
* also hide it for non-pbs storages
Side note: looking at the component, I'd love to refactor it into more
"modern" extjs (view/viewmodel/controller), but for now this is IMHO
good enough.
www/manager6/window/Backup.js | 24 ++++++++++++++++++------
1 file changed, 18 insertions(+), 6 deletions(-)
diff --git a/www/manager6/window/Backup.js b/www/manager6/window/Backup.js
index cb09c7b9..68e9565b 100644
--- a/www/manager6/window/Backup.js
+++ b/www/manager6/window/Backup.js
@@ -53,8 +53,17 @@ Ext.define('PVE.window.Backup', {
},
});
+ let pbsChangeDetectionHelp = Ext.create('Ext.Component', {
+ hidden: true,
+ html: `<i class="fa fa-question-circle" data-qtip="
+ ${gettext("Mode to detect file changes and switch archive encoding format for container backups to Proxmox Backup Server. Not available for VM backups.")}
+ "></i>`,
+ });
+
let pbsChangeDetectionModeSelector = Ext.create({
xtype: 'proxmoxKVComboBox',
+ hidden: true,
+ disabled: true,
fieldLabel: gettext('PBS change detection mode'),
name: 'pbs-change-detection-mode',
deleteEmpty: true,
@@ -126,12 +135,20 @@ Ext.define('PVE.window.Backup', {
if (me.vmtype === 'lxc') {
pbsChangeDetectionModeSelector.setValue('__default__');
pbsChangeDetectionModeSelector.setDisabled(false);
+ pbsChangeDetectionModeSelector.setHidden(false);
+ pbsChangeDetectionHelp.setHidden(false);
+ } else {
+ pbsChangeDetectionModeSelector.setDisabled(true);
+ pbsChangeDetectionModeSelector.setHidden(true);
+ pbsChangeDetectionHelp.setHidden(true);
}
} else {
if (!compressionSelector.getEditable()) {
compressionSelector.setDisabled(false);
}
pbsChangeDetectionModeSelector.setDisabled(true);
+ pbsChangeDetectionModeSelector.setHidden(true);
+ pbsChangeDetectionHelp.setHidden(true);
}
@@ -214,12 +231,7 @@ Ext.define('PVE.window.Backup', {
storagesel,
modeSelector,
protectedCheckbox,
- {
- xtype: 'box',
- html: `<i class="fa fa-question-circle" data-qtip="
- ${gettext("Mode to detect file changes and switch archive encoding format for container backups to Proxmox Backup Server. Not available for VM backups.")}
- "></i>`,
- },
+ pbsChangeDetectionHelp,
pbsChangeDetectionModeSelector,
],
column2: [
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel