From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 892B31FF15E for <inbox@lore.proxmox.com>; Tue, 8 Apr 2025 20:00:39 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 03F79344BC; Tue, 8 Apr 2025 20:00:34 +0200 (CEST) Date: Tue, 8 Apr 2025 19:59:59 +0200 From: Stoiko Ivanov <s.ivanov@proxmox.com> To: Friedrich Weber <f.weber@proxmox.com> Message-ID: <20250408195959.0b1f3aaf@rosa.proxmox.com> In-Reply-To: <20250408163856.116576-1-f.weber@proxmox.com> References: <20250408163856.116576-1-f.weber@proxmox.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.087 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH manager] ui: qemu: hardware view: fix hwrng cap check for unprivileged users X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> On Tue, 8 Apr 2025 18:38:56 +0200 Friedrich Weber <f.weber@proxmox.com> wrote: > Currently, as an unprivileged user with role PVEVMUser the GUI breaks > with an error after navigating to a VM's hardware tab. The reason is > that the frontend checks the GUI capabilites via `caps.mapping.hwrng`, > but `caps.mapping` does not actually have a property called `hwrng`. > > The reason this does not trigger for more privileged users is that all > expressions involving `caps.mapping.hwrng` are short-circuited if the > user has privilege `VM.Config.Type`, so `caps.mapping.hwrng` is never > evaluated. > > Fixes: a47a8afb ("ui: let non-root users configure VirtIO RNG devices") > Signed-off-by: Friedrich Weber <f.weber@proxmox.com> Thanks for tackling this so quick! Managed to reproduce the original issue - your patch fixes it for me as well! it improves the current situation significantly: Reviewed-by: Stoiko Ivanov <s.ivanov@proxmox.com> Tested-by: Stoiko Ivanov <s.ivanov@proxmox.com> In general I think the permissions seems a sensible choice (Mapping.Use on /mapping/hwrng ) (we used Sys.Console for the RNG before (and for other similarly sensitive places, as very high privilege below root@pam only) as talked with Friedrich off-list - understanding how the negation affects what is displayed and what not in the menues took us a bit too long. I'll send a follow-up to unify pci and usb-device add-entry enabling with the the one for the RNG (the backend seems to use the same for all 3) > --- > > Notes: > I wasn't actually sure whether `caps` may have such a 2-level structure > in some cases, but it doesn't seem like it. After applying this patch > to pve-manager: > > % ag 'caps\.[^\[.]+\.' | wc -l > 0 > > www/manager6/qemu/HardwareView.js | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/www/manager6/qemu/HardwareView.js b/www/manager6/qemu/HardwareView.js > index 4ce9908c..b949264f 100644 > --- a/www/manager6/qemu/HardwareView.js > +++ b/www/manager6/qemu/HardwareView.js > @@ -316,8 +316,8 @@ Ext.define('PVE.qemu.HardwareView', { > rows.rng0 = { > group: 45, > tdCls: 'pve-itype-icon-die', > - editor: caps.vms['VM.Config.HWType'] || caps.mapping.hwrng['Mapping.Use'] ? 'PVE.qemu.RNGEdit' : undefined, > - never_delete: !caps.vms['VM.Config.HWType'] && !caps.mapping.hwrng['Mapping.Use'], > + editor: caps.vms['VM.Config.HWType'] || caps.mapping['Mapping.Use'] ? 'PVE.qemu.RNGEdit' : undefined, > + never_delete: !caps.vms['VM.Config.HWType'] && !caps.mapping['Mapping.Use'], > header: gettext("VirtIO RNG"), > }; > for (let i = 0; i < PVE.Utils.hardware_counts.virtiofs; i++) { > @@ -757,7 +757,7 @@ Ext.define('PVE.qemu.HardwareView', { > text: gettext("VirtIO RNG"), > itemId: 'addRng', > iconCls: 'pve-itype-icon-die', > - disabled: !caps.vms['VM.Config.HWType'] && !caps.mapping.hwrng['Mapping.Use'], > + disabled: !caps.vms['VM.Config.HWType'] && !caps.mapping['Mapping.Use'], > handler: editorFactory('RNGEdit'), > }, > { _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel