From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
by lore.proxmox.com (Postfix) with ESMTPS id 74F471FF162
for <inbox@lore.proxmox.com>; Mon, 7 Apr 2025 15:55:53 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 068923FE98;
Mon, 7 Apr 2025 15:55:50 +0200 (CEST)
From: Christoph Heiss <c.heiss@proxmox.com>
To: pve-devel@lists.proxmox.com
Date: Mon, 7 Apr 2025 15:55:07 +0200
Message-ID: <20250407135510.1138958-1-c.heiss@proxmox.com>
X-Mailer: git-send-email 2.48.1
MIME-Version: 1.0
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.030 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: [pve-devel] [PATCH installer] gui: fall back to first found NIC if
no default could be determined
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
If no DHCP server is configured on the network and/or no DHCP lease and
thus network configuration is retrieved, the installer will also be
unable to determine the default interface, aka. the one with the default
gateway set.
Fix it by pre-selecting the first found interface. If we *do* have a
default interface, the index will be later overwritten, but ensures that
always *some* interface is pre-selected in the dropdown.
As it is already checked that the machine has any network interfaces
before starting the installation wizard, it is safe to rely on the fact
that at least one NIC must be present.
For completeness, all the other network inputs already have (hardcoded)
fallbacks, namely 192.168.100.2/24 as address/netmask, 192.168.100.1 as
gateway and the gateway address as DNS server address.
Reported-by: Christian Ebner <c.ebner@proxmox.com>
Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
---
proxinstall | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/proxinstall b/proxinstall
index d396375..bc9ade6 100755
--- a/proxinstall
+++ b/proxinstall
@@ -389,7 +389,7 @@ sub create_ipconf_view {
if $iface->{inet}->{prefix} || $iface->{inet6}->{prefix};
};
- my ($initial_active_device_pos, $initial_addr, $initial_mask) = (-1, undef, undef);
+ my ($initial_active_device_pos, $initial_addr, $initial_mask) = (0, undef, undef);
my $i = 0;
for my $index (sort keys $ipconf->{ifaces}->%*) {
@@ -402,7 +402,8 @@ sub create_ipconf_view {
);
$device_active_map->{$i} = $index;
$device_active_reverse_map->{$iface->{name}} = $i;
- if ($index == $ipconf->{default}) {
+
+ if (defined($ipconf->{default}) && $index == $ipconf->{default}) {
$initial_active_device_pos = $i;
$initial_addr = $iface->{inet}->{addr} || $iface->{inet6}->{addr};
$initial_mask = $iface->{inet}->{prefix} || $iface->{inet6}->{prefix};
@@ -412,7 +413,7 @@ sub create_ipconf_view {
if (my $nic = Proxmox::Install::Config::get_mngmt_nic()) {
$initial_active_device_pos = $device_active_reverse_map->{$nic};
- } elsif ($initial_active_device_pos >= 0) {
+ } else {
my $iface_id = $device_active_map->{$initial_active_device_pos};
my $iface = $ipconf->{ifaces}->{$iface_id};
Proxmox::Install::Config::set_mngmt_nic($iface->{name});
--
2.48.1
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel