From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id A60961FF15C for <inbox@lore.proxmox.com>; Fri, 4 Apr 2025 18:33:45 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E7B2067C; Fri, 4 Apr 2025 18:30:21 +0200 (CEST) From: Gabriel Goller <g.goller@proxmox.com> To: pve-devel@lists.proxmox.com Date: Fri, 4 Apr 2025 18:28:51 +0200 Message-Id: <20250404162908.563060-41-g.goller@proxmox.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250404162908.563060-1-g.goller@proxmox.com> References: <20250404162908.563060-1-g.goller@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.023 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH pve-network v2 15/19] api: ospf: add fabric endpoints X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> From: Stefan Hanreich <s.hanreich@proxmox.com> Add CRUD endpoints for the ospf fabric and node section types. They are implemented in proxmox-perl-rs. Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com> Co-authored-by: Gabriel Goller <g.goller@proxmox.com> Signed-off-by: Gabriel Goller <g.goller@proxmox.com> --- src/PVE/API2/Network/SDN/Fabrics/Makefile | 2 +- src/PVE/API2/Network/SDN/Fabrics/OSPF.pm | 155 ++++++++++++++++++++++ 2 files changed, 156 insertions(+), 1 deletion(-) create mode 100644 src/PVE/API2/Network/SDN/Fabrics/OSPF.pm diff --git a/src/PVE/API2/Network/SDN/Fabrics/Makefile b/src/PVE/API2/Network/SDN/Fabrics/Makefile index af733ad013fd..62d794486ebe 100644 --- a/src/PVE/API2/Network/SDN/Fabrics/Makefile +++ b/src/PVE/API2/Network/SDN/Fabrics/Makefile @@ -1,4 +1,4 @@ -SOURCES=Common.pm OpenFabric.pm OpenFabricNode.pm +SOURCES=Common.pm OpenFabric.pm OpenFabricNode.pm OSPF.pm PERL5DIR=${DESTDIR}/usr/share/perl5 diff --git a/src/PVE/API2/Network/SDN/Fabrics/OSPF.pm b/src/PVE/API2/Network/SDN/Fabrics/OSPF.pm new file mode 100644 index 000000000000..bb32e785aaff --- /dev/null +++ b/src/PVE/API2/Network/SDN/Fabrics/OSPF.pm @@ -0,0 +1,155 @@ +package PVE::API2::Network::SDN::Fabrics::OSPF; + +use strict; +use warnings; + +use PVE::JSONSchema qw(get_standard_option); +use PVE::Tools qw(extract_param $IPV4RE); + +use PVE::API2::Network::SDN::Fabrics::Common; +use PVE::API2::Network::SDN::Fabrics::OSPFNode; + +use PVE::RESTHandler; +use base qw(PVE::RESTHandler); + +# either a 32-bit unsigned integer or an IP address +sub parse_ospf_area { + my ($id, $noerr) = @_; + + if ($id =~ m/\d+/) { + if ($id < 0 || $id > 4294967295) { + return undef if $noerr; + die "$id is a number, but outside of the valid 32-bit unsigned integer range"; + } + } elsif ($id !~ m/^$IPV4RE$/) { + return undef if $noerr; + die "$id is not a valid IPv4 address nor a number"; + } + + return $id; +} + +PVE::JSONSchema::register_format('pve-sdn-fabric-ospf-area', \&parse_ospf_area); + +my $update_fabric_properties = { + digest => get_standard_option('pve-config-digest'), + area => { + type => 'string', + description => 'OSPF Area (either a 32-bit unsigned integer or IPv4 address)', + format => 'pve-sdn-fabric-ospf-area', + }, +}; + +our $fabric_properties = { + fabric_id => get_standard_option('pve-sdn-fabric-id'), + loopback_prefix => get_standard_option('pve-sdn-fabric-loopback-prefix'), + %$update_fabric_properties, +}; + +__PACKAGE__->register_method ({ + subclass => "PVE::API2::Network::SDN::Fabrics::OSPFNode", + path => '{fabric_id}/node', +}); + +__PACKAGE__->register_method({ + name => 'get_fabric', + path => '{fabric_id}', + method => 'GET', + description => 'Get the configuration for an OSPF fabric', + permissions => { + check => ['perm', '/sdn/fabrics/ospf/{fabric_id}', [ 'SDN.Audit', 'SDN.Allocate' ], any => 1], + }, + parameters => { + properties => { + fabric_id => get_standard_option('pve-sdn-fabric-id'), + }, + }, + returns => { + type => 'object', + properties => $fabric_properties, + }, + code => sub { + my ($param) = @_; + + return PVE::API2::Network::SDN::Fabrics::Common::get_fabric("ospf", $param); + }, +}); + +__PACKAGE__->register_method({ + name => 'add_fabric', + path => '/', + method => 'POST', + description => 'Add an OSPF fabric', + protected => 1, + permissions => { + check => ['perm', '/sdn/fabrics/ospf', [ 'SDN.Allocate' ]], + }, + parameters => { + properties => $fabric_properties, + }, + returns => { + type => 'null', + }, + code => sub { + my ($param) = @_; + + PVE::Network::SDN::lock_sdn_config( + sub { + PVE::API2::Network::SDN::Fabrics::Common::add_fabric("ospf", $param); + }, "add sdn fabric failed"); + }, +}); + +__PACKAGE__->register_method({ + name => 'update_fabric', + path => '{fabric_id}', + method => 'PUT', + description => 'Update a OSPF fabric', + protected => 1, + permissions => { + check => ['perm', '/sdn/fabrics/ospf/{fabric_id}', [ 'SDN.Allocate' ]], + }, + parameters => { + properties => $update_fabric_properties, + }, + returns => { + type => 'null', + }, + code => sub { + my ($param) = @_; + + PVE::Network::SDN::lock_sdn_config( + sub { + PVE::API2::Network::SDN::Fabrics::Common::edit_fabric("ospf", $param); + }, "edit sdn fabric failed"); + }, +}); + +__PACKAGE__->register_method({ + name => 'delete_fabric', + path => '{fabric_id}', + method => 'DELETE', + description => 'Delete a OSPF fabric', + protected => 1, + permissions => { + check => ['perm', '/sdn/fabrics/ospf/{fabric_id}', [ 'SDN.Allocate' ]], + }, + parameters => { + properties => { + fabric_id => get_standard_option('pve-sdn-fabric-id'), + }, + }, + returns => { + type => 'null', + }, + code => sub { + my ($param) = @_; + + PVE::Network::SDN::lock_sdn_config( + sub { + PVE::API2::Network::SDN::Fabrics::Common::delete_fabric("ospf", $param); + }, "delete sdn fabric failed"); + }, +}); + +1; -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel