From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	by lore.proxmox.com (Postfix) with ESMTPS id 3D8CA1FF15C
	for <inbox@lore.proxmox.com>; Fri,  4 Apr 2025 18:33:53 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 55BA76EF;
	Fri,  4 Apr 2025 18:30:22 +0200 (CEST)
From: Gabriel Goller <g.goller@proxmox.com>
To: pve-devel@lists.proxmox.com
Date: Fri,  4 Apr 2025 18:28:50 +0200
Message-Id: <20250404162908.563060-40-g.goller@proxmox.com>
X-Mailer: git-send-email 2.39.5
In-Reply-To: <20250404162908.563060-1-g.goller@proxmox.com>
References: <20250404162908.563060-1-g.goller@proxmox.com>
MIME-Version: 1.0
X-SPAM-LEVEL: Spam detection results:  0
 AWL -0.023 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: [pve-devel] [PATCH pve-network v2 14/19] api: openfabric: add node
 endpoints
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>

From: Stefan Hanreich <s.hanreich@proxmox.com>

Add CRUD endpoints for manipulating OpenFabric nodes. They are
implemented in proxmox-perl-rs.

Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
---
 src/PVE/API2/Network/SDN/Fabrics/Makefile     |   2 +-
 .../Network/SDN/Fabrics/OpenFabricNode.pm     | 181 ++++++++++++++++++
 2 files changed, 182 insertions(+), 1 deletion(-)
 create mode 100644 src/PVE/API2/Network/SDN/Fabrics/OpenFabricNode.pm

diff --git a/src/PVE/API2/Network/SDN/Fabrics/Makefile b/src/PVE/API2/Network/SDN/Fabrics/Makefile
index 9caae13ad963..af733ad013fd 100644
--- a/src/PVE/API2/Network/SDN/Fabrics/Makefile
+++ b/src/PVE/API2/Network/SDN/Fabrics/Makefile
@@ -1,4 +1,4 @@
-SOURCES=Common.pm OpenFabric.pm
+SOURCES=Common.pm OpenFabric.pm OpenFabricNode.pm
 
 
 PERL5DIR=${DESTDIR}/usr/share/perl5
diff --git a/src/PVE/API2/Network/SDN/Fabrics/OpenFabricNode.pm b/src/PVE/API2/Network/SDN/Fabrics/OpenFabricNode.pm
new file mode 100644
index 000000000000..5e4d4befe7ab
--- /dev/null
+++ b/src/PVE/API2/Network/SDN/Fabrics/OpenFabricNode.pm
@@ -0,0 +1,181 @@
+package PVE::API2::Network::SDN::Fabrics::OpenFabricNode;
+
+use strict;
+use warnings;
+
+use PVE::JSONSchema qw(get_standard_option);
+
+use PVE::API2::Network::SDN::Fabrics::Common;
+
+use PVE::RESTHandler;
+use base qw(PVE::RESTHandler);
+
+our $hello_interval_option = {
+    type => 'number',
+    description => 'The hello_interval property of the interface',
+    optional => 1,
+    minimum => 1,
+    maximum => 600,
+};
+
+my $interface_properties = {
+    name => {
+	type => 'string',
+	format => 'pve-iface',
+	description => 'Name of the network interface',
+    },
+    ip => {
+	type => 'string',
+	format => 'CIDRv4',
+	description => 'The IPv4 address of the interface',
+	optional => 1,
+    },
+    ipv6 => {
+	type => 'string',
+	format => 'CIDRv6',
+	description => 'The IPv6 address of the interface',
+	optional => 1,
+    },
+    passive => {
+	type => 'boolean',
+	description => 'The passive property of the interface',
+	optional => 1,
+    },
+    hello_interval => $hello_interval_option,
+    csnp_interval => {
+	type => 'number',
+	description => 'The csnp_interval property of the interface',
+	optional => 1,
+	minimum => 1,
+	maximum => 600,
+    },
+    hello_multiplier => {
+	type => 'number',
+	description => 'The hello_multiplier property of the interface',
+	optional => 1,
+	minimum => 2,
+	maximum => 600,
+    },
+};
+
+my $node_properties = {
+    digest => get_standard_option('pve-config-digest'),
+    fabric_id => get_standard_option('pve-sdn-fabric-id'),
+    node_id => get_standard_option('pve-sdn-fabric-node-id'),
+    router_id => {
+	type => 'string',
+	format => 'ip',
+	description => 'The Router-ID of this node (will be converted to a real NET later)',
+    },
+    interfaces => {
+	type => 'array',
+	optional => 1,
+	description => 'List of interfaces on this node that are part of the fabric.',
+	items => {
+	    type => 'string',
+	    description => 'OpenFabric interface configuration.',
+	    format => $interface_properties,
+	},
+    },
+};
+
+__PACKAGE__->register_method({
+    name => 'get_node',
+    path => '{node_id}',
+    method => 'GET',
+    description => 'Get the configuration for a node in an OpenFabric fabric',
+    permissions => {
+	check => ['perm', '/sdn/fabrics/openfabric/{fabric_id}', [ 'SDN.Audit', 'SDN.Allocate' ], any => 1],
+    },
+    parameters => {
+	properties => {
+	    fabric_id => get_standard_option('pve-sdn-fabric-id'),
+	    node_id => get_standard_option('pve-sdn-fabric-node-id'),
+	},
+    },
+    returns => {
+	type => 'object',
+	properties => $node_properties,
+    },
+    code => sub {
+	my ($param) = @_;
+
+	return PVE::API2::Network::SDN::Fabrics::Common::get_node("openfabric", $param);
+    },
+});
+
+__PACKAGE__->register_method({
+    name => 'add_node',
+    path => '/',
+    method => 'POST',
+    description => 'Add a node to an OpenFabric fabric',
+    protected => 1,
+    permissions => {
+	check => ['perm', '/sdn/fabrics/openfabric/{fabric_id}', [ 'SDN.Allocate' ]],
+    },
+    parameters => {
+	properties => $node_properties,
+    },
+    returns => { type => 'null' },
+    code => sub {
+	my ($param) = @_;
+
+	PVE::Network::SDN::lock_sdn_config(
+	    sub {
+		PVE::API2::Network::SDN::Fabrics::Common::add_node("openfabric", $param);
+	    }, "add sdn fabric node failed");
+    },
+});
+
+__PACKAGE__->register_method({
+    name => 'update_node',
+    path => '{node_id}',
+    method => 'PUT',
+    description => 'Update a node in an OpenFabric fabric',
+    protected => 1,
+    permissions => {
+	check => ['perm', '/sdn/fabrics/openfabric/{fabric_id}', [ 'SDN.Allocate' ]],
+    },
+    parameters => {
+	properties => $node_properties,
+    },
+    returns => { type => 'null' },
+    code => sub {
+	my ($param) = @_;
+
+	PVE::Network::SDN::lock_sdn_config(
+	    sub {
+		PVE::API2::Network::SDN::Fabrics::Common::edit_node("openfabric", $param);
+	    }, "edit sdn fabric node failed");
+    },
+});
+
+__PACKAGE__->register_method({
+    name => 'delete_node',
+    path => '{node_id}',
+    method => 'DELETE',
+    description => 'Delete a node from an OpenFabric fabric',
+    protected => 1,
+    permissions => {
+	check => ['perm', '/sdn/fabrics/openfabric/{fabric_id}', [ 'SDN.Allocate' ]],
+    },
+    parameters => {
+	properties => {
+	    fabric_id => get_standard_option('pve-sdn-fabric-id'),
+	    node_id => get_standard_option('pve-sdn-fabric-node-id'),
+	},
+    },
+    returns => {
+	type => 'null',
+    },
+    code => sub {
+	my ($param) = @_;
+
+	PVE::Network::SDN::lock_sdn_config(
+	    sub {
+		PVE::API2::Network::SDN::Fabrics::Common::delete_node("openfabric", $param);
+	    }, "delete sdn fabric node failed");
+    },
+});
+
+1;
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel