From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
by lore.proxmox.com (Postfix) with ESMTPS id C854D1FF189
for <inbox@lore.proxmox.com>; Fri, 4 Apr 2025 14:54:42 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 0503E1F74D;
Fri, 4 Apr 2025 14:54:20 +0200 (CEST)
From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Date: Fri, 4 Apr 2025 14:53:44 +0200
Message-Id: <20250404125345.3244659-9-d.csapak@proxmox.com>
X-Mailer: git-send-email 2.39.5
In-Reply-To: <20250404125345.3244659-1-d.csapak@proxmox.com>
References: <20250404125345.3244659-1-d.csapak@proxmox.com>
MIME-Version: 1.0
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.023 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: [pve-devel] [PATCH qemu-server v3 8/8] api: qemu machine
capabilities: add description for pveX variants
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
and retroactively add descriptions for previous bumps.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
changes from v2:
* added additional sentence to new machine model description
PVE/API2/Qemu/Machine.pm | 9 +++++++++
PVE/QemuServer/Machine.pm | 15 +++++++++++++++
2 files changed, 24 insertions(+)
diff --git a/PVE/API2/Qemu/Machine.pm b/PVE/API2/Qemu/Machine.pm
index bbd814f0..83145f89 100644
--- a/PVE/API2/Qemu/Machine.pm
+++ b/PVE/API2/Qemu/Machine.pm
@@ -46,6 +46,12 @@ __PACKAGE__->register_method({
type => 'string',
description => "The machine version.",
},
+ description => {
+ type => 'string',
+ optional => 1,
+ description => 'Notable changes that version introduces, only used for +pveX"
+ ." versions.',
+ },
},
},
},
@@ -67,6 +73,9 @@ __PACKAGE__->register_method({
version => $version,
};
+ my $desc = PVE::QemuServer::Machine::get_pve_version_description($version);
+ $entry->{description} = $desc if defined($desc);
+
push $to_add->@*, $entry;
}
}
diff --git a/PVE/QemuServer/Machine.pm b/PVE/QemuServer/Machine.pm
index 47667aac..2056aad0 100644
--- a/PVE/QemuServer/Machine.pm
+++ b/PVE/QemuServer/Machine.pm
@@ -15,6 +15,21 @@ our $PVE_MACHINE_VERSION = {
'9.2' => 1,
};
+# When bumping the pveX version, add a description why.
+my $PVE_MACHINE_VERSION_DESCRIPTIONS = {
+ '4.1+pve1' => 'Introduction of pveX versioning, no changes.',
+ '4.1+pve2' => 'Increases supported SCSI drive count.',
+ '9.2+pve1' => 'Disables S3/S4 power states. These are often problematic in virtualized guests.',
+};
+
+# returns the description of a given machine version with pve version, e.g. 9.2+pve1 or undef if
+# there is none
+sub get_pve_version_description {
+ my ($version) = @_;
+
+ return $PVE_MACHINE_VERSION_DESCRIPTIONS->{$version};
+}
+
my $machine_fmt = {
type => {
default_key => 1,
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel