From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id B1D7F1FF189 for <inbox@lore.proxmox.com>; Fri, 4 Apr 2025 14:47:41 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BA76C1EFAE; Fri, 4 Apr 2025 14:47:29 +0200 (CEST) From: Christoph Heiss <c.heiss@proxmox.com> To: pve-devel@lists.proxmox.com Date: Fri, 4 Apr 2025 14:46:45 +0200 Message-ID: <20250404124651.1283950-1-c.heiss@proxmox.com> X-Mailer: git-send-email 2.48.1 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.030 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [install.pm, proxmox.com, bootdisk.rs, zfs-arc-max.pl, runenv.pm] Subject: [pve-devel] [PATCH installer 0/3] fix #6285: always set up zfs modprobe configuration X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> Fixes #6285 [0]. This also came up quite a few times already in the forum, most recently [1] (german). Since we do expose the option in the UI for all products nowadays (on ZFS-on-root installations only tho), just always write to /etc/modprobe.d/zfs.conf. [0] https://bugzilla.proxmox.com/show_bug.cgi?id=6285 [1] https://forum.proxmox.com/threads/ram-auslastung-nimmt-%C3%BCber-die-zeit-drastisch-zu.164527/#post-760989 Testing ======= Tested for each product PVE, PBS, PMG the following - install on ZFS, not touching the ARC size setting - install on ZFS, set some explicit value for ARC size - installing on non-ZFS such as ext4 .. and checking afterwards that /etc/modprobe.d/zfs.conf was written and contained respectively - the default value for the product - the set value - again the default value for the product Also tested each case with the auto-installer for PVE and PMG. Diffstat ======== Christoph Heiss (3): run env: always return proper value for default zfs max arc size tui: bootdisk: always return proper value for default zfs max arc size fix #6285: install: always set up zfs modprobe configuration Proxmox/Install.pm | 11 +++--- Proxmox/Install/RunEnv.pm | 9 +++-- proxmox-tui-installer/src/views/bootdisk.rs | 32 +++++++++------- test/zfs-arc-max.pl | 42 +++++++++++++-------- 4 files changed, 57 insertions(+), 37 deletions(-) -- 2.48.1 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel