From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
by lore.proxmox.com (Postfix) with ESMTPS id 889601FF18C
for <inbox@lore.proxmox.com>; Mon, 24 Mar 2025 16:03:46 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 4D4911F088;
Mon, 24 Mar 2025 16:03:41 +0100 (CET)
From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Date: Mon, 24 Mar 2025 16:03:37 +0100
Message-Id: <20250324150337.3221726-3-d.csapak@proxmox.com>
X-Mailer: git-send-email 2.39.5
In-Reply-To: <20250324150337.3221726-1-d.csapak@proxmox.com>
References: <20250324150337.3221726-1-d.csapak@proxmox.com>
MIME-Version: 1.0
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.022 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: [pve-devel] [PATCH novnc 2/2] fix broken 'extra keys' images
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
this is currently broken upstream and it's unclear if this is the
correct fix, so add it seperately until upstream fixes it themselves.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
.../patches/0020-fix-broken-extra-keys.patch | 32 +++++++++++++++++++
debian/patches/series | 1 +
2 files changed, 33 insertions(+)
create mode 100644 debian/patches/0020-fix-broken-extra-keys.patch
diff --git a/debian/patches/0020-fix-broken-extra-keys.patch b/debian/patches/0020-fix-broken-extra-keys.patch
new file mode 100644
index 0000000..c072210
--- /dev/null
+++ b/debian/patches/0020-fix-broken-extra-keys.patch
@@ -0,0 +1,32 @@
+From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
+From: Dominik Csapak <d.csapak@proxmox.com>
+Date: Mon, 24 Mar 2025 14:25:39 +0100
+Subject: [PATCH] fix broken extra keys
+
+commit:
+14f9ea5: ("Fix settings panel layout on small screens")
+
+changed the selector for the max-width calculation here to include the
+images type, but this was actually not intended.
+
+Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
+---
+ app/styles/base.css | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/app/styles/base.css b/app/styles/base.css
+index 6e9b25d..948074c 100644
+--- a/app/styles/base.css
++++ b/app/styles/base.css
+@@ -478,7 +478,7 @@ html {
+ .noVNC_panel button,
+ .noVNC_panel select,
+ .noVNC_panel textarea,
+-.noVNC_panel input:not([type=checkbox]):not([type=radio]) {
++.noVNC_panel input:not([type=checkbox]):not([type=radio]):not([type=image]) {
+ margin-left: 6px;
+ /* Prevent inputs in panels from being too wide */
+ max-width: calc(100% - 6px - var(--input-xpadding) * 2);
+--
+2.39.5
+
diff --git a/debian/patches/series b/debian/patches/series
index 212add7..66ee38e 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -17,3 +17,4 @@
0017-make-error-hideable.patch
0018-show-start-button-on-not-running-vm-ct.patch
0019-show-clipboard-button.patch
+0020-fix-broken-extra-keys.patch
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel