From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
by lore.proxmox.com (Postfix) with ESMTPS id 1BB811FF16E
for <inbox@lore.proxmox.com>; Mon, 17 Mar 2025 15:18:46 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 798925781;
Mon, 17 Mar 2025 15:18:00 +0100 (CET)
From: Christoph Heiss <c.heiss@proxmox.com>
To: pve-devel@lists.proxmox.com
Date: Mon, 17 Mar 2025 15:11:49 +0100
Message-ID: <20250317141152.1247324-13-c.heiss@proxmox.com>
X-Mailer: git-send-email 2.48.1
In-Reply-To: <20250317141152.1247324-1-c.heiss@proxmox.com>
References: <20250317141152.1247324-1-c.heiss@proxmox.com>
MIME-Version: 1.0
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.027 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: [pve-devel] [PATCH manager 12/14] ui: window: Migrate: add checkbox
for migrating VM conntrack state
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
Adds a new checkbox to the migration dialog, if it is a
live/online-migration and both the source and target nodes have support
for our dbus-vmstate helper.
If the checkbox is active, it passes along the `with-conntrack-state`
parameter to the migrate API call.
Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
---
www/manager6/window/Migrate.js | 73 ++++++++++++++++++++++++++++++++--
1 file changed, 69 insertions(+), 4 deletions(-)
diff --git a/www/manager6/window/Migrate.js b/www/manager6/window/Migrate.js
index 78d03921e..e8a68eed9 100644
--- a/www/manager6/window/Migrate.js
+++ b/www/manager6/window/Migrate.js
@@ -28,8 +28,9 @@ Ext.define('PVE.window.Migrate', {
allowedNodes: undefined,
overwriteLocalResourceCheck: false,
hasLocalResources: false,
+ withConntrackState: true,
+ bothHaveDbusVmstate: false,
},
-
},
formulas: {
@@ -59,6 +60,9 @@ Ext.define('PVE.window.Migrate', {
return false;
}
},
+ conntrackStateCheckboxHidden: get =>
+ !get('running') || get('vmtype') !== 'qemu' ||
+ !get('migration.bothHaveDbusVmstate'),
},
},
@@ -133,6 +137,10 @@ Ext.define('PVE.window.Migrate', {
params.force = 1;
}
+ if (vm.get('migration.bothHaveDbusVmstate') && vm.get('migration.withConntrackState')) {
+ params['with-conntrack-state'] = 1;
+ }
+
Proxmox.Utils.API2Request({
params: params,
url: '/nodes/' + vm.get('nodename') + '/' + vm.get('vmtype') + '/' + vm.get('vmid') + '/migrate',
@@ -199,12 +207,28 @@ Ext.define('PVE.window.Migrate', {
method: 'GET',
});
migrateStats = result.data;
- me.fetchingNodeMigrateInfo = false;
} catch (error) {
Ext.Msg.alert(gettext('Error'), error.htmlStatus);
+ me.fetchingNodeMigrateInfo = false;
return;
}
+ const target = me.lookup('pveNodeSelector').value;
+ let targetCapabilities = {};
+
+ try {
+ const { result } = await Proxmox.Async.api2({
+ url: `/nodes/${target}/capabilities/qemu/migration`,
+ method: 'GET',
+ });
+ targetCapabilities = result.data;
+ } catch (err) {
+ // In the case the target node does not (yet) support the
+ // `capabilites/qemu/migration` endpoint, just ignore it.
+ }
+
+ me.fetchingNodeMigrateInfo = false;
+
if (migrateStats.running) {
vm.set('running', true);
}
@@ -217,7 +241,6 @@ Ext.define('PVE.window.Migrate', {
if (migrateStats.allowed_nodes) {
migration.allowedNodes = migrateStats.allowed_nodes;
- let target = me.lookup('pveNodeSelector').value;
if (target.length && !migrateStats.allowed_nodes.includes(target)) {
let disallowed = migrateStats.not_allowed_nodes[target] ?? {};
if (disallowed.unavailable_storages !== undefined) {
@@ -303,6 +326,29 @@ Ext.define('PVE.window.Migrate', {
});
}
+ migration.bothHaveDbusVmstate = migrateStats['has-dbus-vmstate'] && targetCapabilities['has-dbus-vmstate'];
+ if (vm.get('running')) {
+ if (migration.withConntrackState && !migrateStats['has-dbus-vmstate']) {
+ migration.preconditions.push({
+ text: gettext('Cannot migrate conntrack state, source node is lacking support. Active network connections might get dropped.'),
+ severity: 'warning',
+ });
+ }
+ if (migration.withConntrackState && !targetCapabilities['has-dbus-vmstate']) {
+ migration.preconditions.push({
+ text: gettext('Cannot migrate conntrack state, target node is lacking support. Active network connections might get dropped.'),
+ severity: 'warning',
+ });
+ }
+
+ if (migration.bothHaveDbusVmstate && !migration.withConntrackState) {
+ migration.preconditions.push({
+ text: gettext('Conntrack state migration disabled. Active network connections might get dropped.'),
+ severity: 'warning',
+ });
+ }
+ }
+
vm.set('migration', migration);
},
checkLxcPreconditions: function(resetMigrationPossible) {
@@ -394,7 +440,26 @@ Ext.define('PVE.window.Migrate', {
extraArg: true,
},
},
- }],
+ },
+ {
+ xtype: 'proxmoxcheckbox',
+ name: 'withConntrackState',
+ fieldLabel: gettext('Conntrack state'),
+ autoEl: {
+ tag: 'div',
+ 'data-qtip': gettext('Enables live migration of conntrack entries for this VM.'),
+ },
+ bind: {
+ hidden: '{conntrackStateCheckboxHidden}',
+ value: '{migration.withConntrackState}',
+ },
+ listeners: {
+ change: {
+ fn: 'checkMigratePreconditions',
+ extraArg: true,
+ },
+ },
+ }],
},
],
},
--
2.48.1
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel