From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
by lore.proxmox.com (Postfix) with ESMTPS id 0FEDB1FF15E
for <inbox@lore.proxmox.com>; Tue, 11 Mar 2025 16:05:32 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 947C614379;
Tue, 11 Mar 2025 16:05:23 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1741705520;
x=1742310320; d=canarybit.eu; s=rsa2;
h=content-transfer-encoding:mime-version:references:in-reply-to:message-id:date:
subject:cc:to:from:from;
bh=lcL4EdUUSX5eYyZA2HRqNguAfzGHvFY7CpddJiQ+EBI=;
b=PMSSel2isIR0s/JHJCdZ2Yl0wl7qFNKt31NiXD0f9rU5CFFMJ4n7WOW4+eLFMBQ+2g0BTquhHFhIa
U5XbkhXmhFwDqg7E2xfmeHcZ21GoXGD6BkGhxRb0rPpG8iw+N6p9m5gOvcc+cc/8oig5ZJn5+Xetr+
Txt6/AcrNuSay8XzBan6j6V9ruJ5oyxnHQCOZceU628+3+MKRmqt7yUbAhWDQbeYKzp/NfpPYUI7WI
CngfmQ/WRsdnFvqYeiMJQhMQ6efckEW1RglXmsrlfLLVtmkNlgSJ1N3lDkBU0+NhuaprDSCmXDLpKi
r9icSISHFjiTYQSnT8iZGvXDOZ0Lotw==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; t=1741705520;
x=1742310320; d=canarybit.eu; s=ed2;
h=content-transfer-encoding:mime-version:references:in-reply-to:message-id:date:
subject:cc:to:from:from;
bh=lcL4EdUUSX5eYyZA2HRqNguAfzGHvFY7CpddJiQ+EBI=;
b=XUfGIB/MaDdGY9lsP+oyqBZ12OGJc49t0Z8SeuKAU5qxlUbn0g3FzPiSEG1H3+G/Bw1qeZssa8VgO
ck9YcS1Bw==
X-HalOne-ID: 3fc0cf25-fe8a-11ef-9e2a-d7c209f8bd06
From: Philipp Giersfeld <philipp.giersfeld@canarybit.eu>
To: pve-devel@lists.proxmox.com
Date: Tue, 11 Mar 2025 16:04:54 +0100
Message-Id: <20250311150456.4071232-3-philipp.giersfeld@canarybit.eu>
X-Mailer: git-send-email 2.39.5
In-Reply-To: <20250311150456.4071232-1-philipp.giersfeld@canarybit.eu>
References: <20250311150456.4071232-1-philipp.giersfeld@canarybit.eu>
MIME-Version: 1.0
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.148 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DKIM_SIGNED 0.1 Message has a DKIM or DK signature,
not necessarily valid
DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
domain
DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
domain DMARC_MISSING 0.1 Missing DMARC policy
RCVD_IN_DNSWL_NONE -0.0001 Sender listed at https://www.dnswl.org/,
no trust
SPF_HELO_PASS -0.001 SPF: HELO matches SPF record
SPF_NONE 0.001 SPF: sender does not publish an SPF Record
Subject: [pve-devel] [PATCH qemu-server v4 2/4] Convert policy calculation
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
Convert policy calculation to use shift operators and OR operation
instead of binary numbers and addition.
Signed-off-by: Philipp Giersfeld <philipp.giersfeld@canarybit.eu>
Reviewed-by: Daniel Kral <d.kral@proxmox.com>
Reviewed-by: Fiona Ebner <f.ebner@proxmox.com>
Tested-by: Markus Frank <m.frank@proxmox.com>
---
changes since v3: https://lists.proxmox.com/pipermail/pve-devel/2025-February/068578.html
* Fix typo in commit description
PVE/QemuServer/CPUConfig.pm | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/PVE/QemuServer/CPUConfig.pm b/PVE/QemuServer/CPUConfig.pm
index e65d8c26..ad0be16e 100644
--- a/PVE/QemuServer/CPUConfig.pm
+++ b/PVE/QemuServer/CPUConfig.pm
@@ -846,12 +846,12 @@ sub get_amd_sev_object {
# guest policy bit calculation as described here:
# https://documentation.suse.com/sles/15-SP5/html/SLES-amd-sev/article-amd-sev.html#table-guestpolicy
- my $policy = 0b0000;
- $policy += 0b0001 if $amd_sev_conf->{'no-debug'};
- $policy += 0b0010 if $amd_sev_conf->{'no-key-sharing'};
- $policy += 0b0100 if $amd_sev_conf->{type} eq 'es';
+ my $policy = 0;
+ $policy |= 1 << 0 if $amd_sev_conf->{'no-debug'};
+ $policy |= 1 << 1 if $amd_sev_conf->{'no-key-sharing'};
+ $policy |= 1 << 2 if $amd_sev_conf->{type} eq 'es';
# disable migration with bit 3 nosend to prevent amd-sev-migration-attack
- $policy += 0b1000;
+ $policy |= 1 << 3;
$sev_mem_object .= ',policy='.sprintf("%#x", $policy);
$sev_mem_object .= ',kernel-hashes=on' if ($amd_sev_conf->{'kernel-hashes'});
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel