From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 0B62C1FF16F for ; Thu, 27 Feb 2025 15:34:03 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1557329974; Thu, 27 Feb 2025 15:34:00 +0100 (CET) From: Aaron Lauterer To: pve-devel@lists.proxmox.com Date: Thu, 27 Feb 2025 15:33:56 +0100 Message-Id: <20250227143356.1089350-1-a.lauterer@proxmox.com> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.033 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager v2] fix #5894: pvestatd: improve broadcast of node version-info X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Until now, the pvestatd did broadcast the pve-manager version only once after startup of the service. But there are some situations, where the local pmxcfs (pve-cluster) restarts and loses that information. Basically everytime we restart the pmxcfs without restarting pvestatd too. For example, on a cluster join, or if the pmxcfs has been restarted manually. By additionally checking if the local kv-store of the pmxcfs has any version info for the node, we can decide if another broadcast is necessary. Therefore after the next run of pvestatd, we should have the full version info available again. Signed-off-by: Aaron Lauterer --- changes since v2: * use scalar() around check if keys are present * mention bug this fixes PVE/Service/pvestatd.pm | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/PVE/Service/pvestatd.pm b/PVE/Service/pvestatd.pm index 7fa003fe..ff9a5c8b 100755 --- a/PVE/Service/pvestatd.pm +++ b/PVE/Service/pvestatd.pm @@ -527,7 +527,10 @@ sub update_sdn_status { my $broadcast_version_info_done = 0; my sub broadcast_version_info : prototype() { - if (!$broadcast_version_info_done) { + if ( + !$broadcast_version_info_done + || !scalar(keys PVE::Cluster::get_node_kv('version-info', $nodename)->%*) + ) { PVE::Cluster::broadcast_node_kv( 'version-info', encode_json(PVE::pvecfg::version_info()), -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel