From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 19BA61FF168 for <inbox@lore.proxmox.com>; Tue, 18 Feb 2025 12:12:37 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CFD259D6B; Tue, 18 Feb 2025 12:12:11 +0100 (CET) From: Filip Schauer <f.schauer@proxmox.com> To: pve-devel@lists.proxmox.com Date: Tue, 18 Feb 2025 12:11:00 +0100 Message-Id: <20250218111102.40055-8-f.schauer@proxmox.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250218111102.40055-1-f.schauer@proxmox.com> References: <20250218111102.40055-1-f.schauer@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.020 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_SHORT 0.001 Use of a URL Shortener for very short URL SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager v4 7/9] ui: remove warning about entropy starvation of /dev/random X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> Remove the warning about entropy-starvation when using /dev/random as the entropy source. This concern no longer applies since the removal of the blocking entropy pool in kernel version 5.6. [1] [2] [1] https://git.kernel.org/torvalds/c/acd77500aa8a337baa6d853568c4b55aca48e20f [2] https://lwn.net/Articles/808575/ Signed-off-by: Filip Schauer <f.schauer@proxmox.com> --- www/manager6/qemu/RNGEdit.js | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/www/manager6/qemu/RNGEdit.js b/www/manager6/qemu/RNGEdit.js index e34e2c08..097e08c3 100644 --- a/www/manager6/qemu/RNGEdit.js +++ b/www/manager6/qemu/RNGEdit.js @@ -35,12 +35,6 @@ Ext.define('PVE.qemu.RNGInputPanel', { limitWarning.setHidden(!!newVal); }, }, - '#source': { - change: function(el, newVal) { - let limitWarning = this.lookupReference('sourceWarning'); - limitWarning.setHidden(newVal !== '/dev/random'); - }, - }, }, }, @@ -77,13 +71,6 @@ Ext.define('PVE.qemu.RNGInputPanel', { labelWidth: 130, emptyText: '1000', }, - { - xtype: 'displayfield', - reference: 'sourceWarning', - value: gettext('Using /dev/random as entropy source is discouraged, as it can lead to host entropy starvation. /dev/urandom is preferred, and does not lead to a decrease in security in practice.'), - userCls: 'pmx-hint', - hidden: true, - }, { xtype: 'displayfield', reference: 'limitWarning', -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel