From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 130C51FF16E for <inbox@lore.proxmox.com>; Mon, 17 Feb 2025 13:18:39 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0D8B21EC03; Mon, 17 Feb 2025 13:18:32 +0100 (CET) From: Daniel Kral <d.kral@proxmox.com> To: pve-devel@lists.proxmox.com Date: Mon, 17 Feb 2025 13:17:45 +0100 Message-Id: <20250217121748.117222-3-d.kral@proxmox.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250217121748.117222-1-d.kral@proxmox.com> References: <20250217121748.117222-1-d.kral@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.008 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH installer 2/5] auto-installer: first-boot: allow snake- and kebabcased property names X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> The default case for property names in TOML configuration files is de facto snake_case. The answer file for the auto-installer adapted this, but this causes inconsistencies with the property names in other Proxmox config file formats, which are preferably in kebab-case. The properties for the "first-boot" section were intentionally introduced in kebab-case to steer away from snake_cased to kebab-cased property names. Since this caused some initial confusion for users [0], allow both cases for the time being and deprecate the snake_cased variant of all properties in a future major version. [0] https://bugzilla.proxmox.com/show_bug.cgi?id=5973 Signed-off-by: Daniel Kral <d.kral@proxmox.com> --- proxmox-auto-installer/src/answer.rs | 1 + 1 file changed, 1 insertion(+) diff --git a/proxmox-auto-installer/src/answer.rs b/proxmox-auto-installer/src/answer.rs index 38a048b..e8614d2 100644 --- a/proxmox-auto-installer/src/answer.rs +++ b/proxmox-auto-installer/src/answer.rs @@ -118,6 +118,7 @@ pub struct FirstBootHookInfo { /// Retrieve the post-install script from a URL, if source == "from-url". pub url: Option<String>, /// SHA256 cert fingerprint if certificate pinning should be used, if source == "from-url". + #[serde(alias = "cert_fingerprint")] pub cert_fingerprint: Option<String>, } -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel