From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
by lore.proxmox.com (Postfix) with ESMTPS id B47431FF15E
for <inbox@lore.proxmox.com>; Tue, 11 Feb 2025 17:09:07 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 7CA0D3272;
Tue, 11 Feb 2025 17:08:39 +0100 (CET)
From: Daniel Kral <d.kral@proxmox.com>
To: pve-devel@lists.proxmox.com
Date: Tue, 11 Feb 2025 17:07:59 +0100
Message-Id: <20250211160825.254167-6-d.kral@proxmox.com>
X-Mailer: git-send-email 2.39.5
In-Reply-To: <20250211160825.254167-1-d.kral@proxmox.com>
References: <20250211160825.254167-1-d.kral@proxmox.com>
MIME-Version: 1.0
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.012 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: [pve-devel] [PATCH pve-storage v2 5/5] vdisk_alloc: add optional
assertion for volume's content type
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
Allow a caller to specify the volume's intended content type and assert
whether the specified content type may be stored on the specified
storage before allocating any volume.
Signed-off-by: Daniel Kral <d.kral@proxmox.com>
---
changes since v1:
- add assertion at `vdisk_alloc` instead of wrapper `alloc_volume_disk`
src/PVE/Storage.pm | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/src/PVE/Storage.pm b/src/PVE/Storage.pm
index 3776565..96d4e41 100755
--- a/src/PVE/Storage.pm
+++ b/src/PVE/Storage.pm
@@ -1059,6 +1059,13 @@ Specifies the name of the new volume.
If undefined, the name will be generated with C<PVE::Storage::Plugin::find_free_diskname>.
+=item * C<< $vtype => $string >>
+
+Specifies the content type of the new volume, which can be one of C<'images'>, C<'rootdir'>,
+C<'vztmpl'>, C<'iso'>, C<'backup'>, C<'snippets'> or C<'import'>.
+
+If set, this will assert whether the storage supports the specified content type.
+
=back
Returns the identifier for the new volume in the format C<"$storeid:$volname">.
@@ -1069,6 +1076,7 @@ sub vdisk_alloc : prototype($$$$$;%) {
my ($cfg, $storeid, $vmid, $fmt, $size, $opts) = @_;
my $name = $opts->{name};
+ my $vtype = $opts->{vtype};
die "no storage ID specified\n" if !$storeid;
@@ -1086,6 +1094,8 @@ sub vdisk_alloc : prototype($$$$$;%) {
activate_storage($cfg, $storeid);
+ assert_content_type_supported($cfg, $storeid, $vtype) if $vtype;
+
my $plugin = PVE::Storage::Plugin->lookup($scfg->{type});
# lock shared storage
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel