From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
by lore.proxmox.com (Postfix) with ESMTPS id 9E4071FF168
for <inbox@lore.proxmox.com>; Tue, 4 Feb 2025 16:24:37 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 1F7701A164;
Tue, 4 Feb 2025 16:24:37 +0100 (CET)
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Date: Tue, 4 Feb 2025 16:24:28 +0100
Message-Id: <20250204152428.146743-1-f.ebner@proxmox.com>
X-Mailer: git-send-email 2.39.5
MIME-Version: 1.0
X-SPAM-LEVEL: Spam detection results: 0
AWL -0.047 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
information. [proxmox.com, qmphelpers.pm]
Subject: [pve-devel] [PATCH qemu-server] qmp helpers: device add: use HMP
interface
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
Fixes device hotplug in combination with QEMU 9.2.
QEMU commit be93fd5372 ("qdev-monitor: avoid QemuOpts in QMP device_add")
notes:
> This patch changes the behavior of QMP device_add but not HMP
> device_add. QMP clients that sent incorrectly typed device_add QMP
> commands no longer work. This is a breaking change but clients should be
> using the correct types already.
The qemu_deviceadd() helper does not have the required type
information right now, so switch to using HMP, which still behaves the
same when passing a device commandline string. QEMU commit be93fd5372
fixes passing in complex properties via JSON, but the qemu_deviceadd()
helper never uses any such, as it already only received a string (and
naively split it up).
Use HMP for 'device_del' too, simply to keep the qemu_deviceadd() and
qemu_devicedel() helpers consistent.
Switching back to QMP using the correct types in the JSON can still be
done later. Unfortunately, 'qmp-query-schema' does not provide
device-specific types, so another way is needed.
The timeout of 60 seconds is used, because that is the same that's
currently used by the 'drive_add' HMP commands and a too low timeout
is known to cause issues [0]. While 'drive_del' uses 10 minutes, there
were no issues reported with the 'device_del' operations using the
default timeout until now, but it still makes sense to increase,
because for some devices IO might need to happen during detach, so use
60 seconds for now too.
While this fixes the singular issue reported in [0] by accident,
increasing the QMP timeout like in the patches proposed there will be
needed when switching back to QMP and also covers object_{add,del}.
[0]: https://bugzilla.proxmox.com/show_bug.cgi?id=5985
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
PVE/QemuServer/QMPHelpers.pm | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/PVE/QemuServer/QMPHelpers.pm b/PVE/QemuServer/QMPHelpers.pm
index 1bc9e5dc..332442f3 100644
--- a/PVE/QemuServer/QMPHelpers.pm
+++ b/PVE/QemuServer/QMPHelpers.pm
@@ -25,15 +25,14 @@ sub qemu_deviceadd {
my ($vmid, $devicefull) = @_;
$devicefull = "driver=".$devicefull;
- my %options = split(/[=,]/, $devicefull);
- mon_cmd($vmid, "device_add" , %options);
+ PVE::QemuServer::Monitor::hmp_cmd($vmid, "device_add $devicefull", 60);
}
sub qemu_devicedel {
my ($vmid, $deviceid) = @_;
- my $ret = mon_cmd($vmid, "device_del", id => $deviceid);
+ PVE::QemuServer::Monitor::hmp_cmd($vmid, "device_del $deviceid", 60);
}
sub qemu_objectadd {
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel