From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
by lore.proxmox.com (Postfix) with ESMTPS id CF6191FF16F
for <inbox@lore.proxmox.com>; Thu, 30 Jan 2025 12:31:45 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 2DFA1F989;
Thu, 30 Jan 2025 12:31:29 +0100 (CET)
From: Daniel Herzig <d.herzig@proxmox.com>
To: pve-devel@lists.proxmox.com
Date: Thu, 30 Jan 2025 12:31:20 +0100
Message-Id: <20250130113121.157273-6-d.herzig@proxmox.com>
X-Mailer: git-send-email 2.39.5
In-Reply-To: <20250130113121.157273-1-d.herzig@proxmox.com>
References: <20250130113121.157273-1-d.herzig@proxmox.com>
MIME-Version: 1.0
X-SPAM-LEVEL: Spam detection results: 0
AWL -0.589 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery
methods
RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_NONE 0.001 SPF: sender does not publish an SPF Record
Subject: [pve-devel] [PATCH pve-manager v3 5/6] fix #4225: ui: qemu: cdedit:
enable 'Essential' checkbox for isos
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
Enables the 'Essential' checkbox for the IsoSelector.
If the parameter `essential` is not set in the configuration,
it will be assumed to be true, to avoid breaking changes.
The box is checked by default for the same reason.
If unchecked, `essential=0` is written to the configuration and the VM
will attempt to start, even if the file or underlying storage is not
available (by temporarily setting the value to 'none,media=cdrom').
Signed-off-by: Daniel Herzig <d.herzig@proxmox.com>
---
www/manager6/qemu/CDEdit.js | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/www/manager6/qemu/CDEdit.js b/www/manager6/qemu/CDEdit.js
index 3cc16205..b115debc 100644
--- a/www/manager6/qemu/CDEdit.js
+++ b/www/manager6/qemu/CDEdit.js
@@ -12,6 +12,7 @@ Ext.define('PVE.qemu.CDInputPanel', {
me.drive.media = 'cdrom';
if (values.mediaType === 'iso') {
me.drive.file = values.cdimage;
+ me.drive.essential = values.essential ? undefined : '0';
} else if (values.mediaType === 'cdrom') {
me.drive.file = 'cdrom';
} else {
@@ -44,6 +45,11 @@ Ext.define('PVE.qemu.CDInputPanel', {
} else {
values.mediaType = 'iso';
values.cdimage = drive.file;
+ if (drive.essential === '1' || drive.essential === undefined) {
+ values.essential = '1';
+ } else {
+ values.essential = '0';
+ }
}
me.drive = drive;
@@ -88,6 +94,7 @@ Ext.define('PVE.qemu.CDInputPanel', {
cdImageField.validate();
} else {
cdImageField.reset();
+ delete me.drive.essential;
}
},
},
@@ -98,6 +105,7 @@ Ext.define('PVE.qemu.CDInputPanel', {
nodename: me.nodename,
insideWizard: me.insideWizard,
name: 'cdimage',
+ showRequired: true,
});
items.push(me.isosel);
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel