[pve-devel] [PATCH ha-manager 1/2] test: ha tester: drop unused import

[pve-devel] [PATCH ha-manager 1/2] test: ha tester: drop unused import

[Fiona Ebner]

There is no user of File::Path remaining after commit 787b66e
("SimCluster: setup status dir inside new") which was the only user
of remove_tree(). make_path() was not used at all according to git
history.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 src/test/ha-tester.pl | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/test/ha-tester.pl b/src/test/ha-tester.pl
index 8b73a58..8ff1629 100755
--- a/src/test/ha-tester.pl
+++ b/src/test/ha-tester.pl
@@ -4,8 +4,6 @@ use strict;
 use warnings;
 use Getopt::Long;
 
-use File::Path qw(make_path remove_tree);
-
 my $opt_nodiff;
 my $opt_nofail;
 my $opt_notestout;
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH ha-manager 2/2] test: ha tester: remove trailing whitespace

[Fiona Ebner]

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 src/test/ha-tester.pl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/test/ha-tester.pl b/src/test/ha-tester.pl
index 8ff1629..0693133 100755
--- a/src/test/ha-tester.pl
+++ b/src/test/ha-tester.pl
@@ -47,7 +47,7 @@ sub do_run_test {
     my $logexpect = "$dir/log.expect";
 
     if (-f $logexpect) {
-	my $cmd = ['diff', '-u', $logexpect, $logfile]; 
+	my $cmd = ['diff', '-u', $logexpect, $logfile];
 	$res = system(@$cmd);
 	return "test '$dir' failed\n" if $res != 0;
     } else {
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH ha-manager 1/2] test: ha tester: drop unused import

[Thomas Lamprecht]

Am 22.01.25 um 11:55 schrieb Fiona Ebner:
> There is no user of File::Path remaining after commit 787b66e
> ("SimCluster: setup status dir inside new") which was the only user
> of remove_tree(). make_path() was not used at all according to git
> history.
> 
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
>  src/test/ha-tester.pl | 2 --
>  1 file changed, 2 deletions(-)
> 
>

applied, thanks!

I followed-up with another commit that does the same for the fence config
test script.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH ha-manager 2/2] test: ha tester: remove trailing whitespace

[Thomas Lamprecht]

Am 22.01.25 um 11:55 schrieb Fiona Ebner:
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
>  src/test/ha-tester.pl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
>

applied, thanks!


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel