From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH qemu-server v3 08/18] move get_installed_machine_version() helper to machine module
Date: Fri, 17 Jan 2025 13:08:07 +0100 [thread overview]
Message-ID: <20250117120817.41443-9-f.ebner@proxmox.com> (raw)
In-Reply-To: <20250117120817.41443-1-f.ebner@proxmox.com>
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
PVE/QemuServer.pm | 9 +--------
PVE/QemuServer/Machine.pm | 7 +++++++
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 82795767..ee7bb017 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -3271,13 +3271,6 @@ sub vga_conf_has_spice {
return $1 || 1;
}
-sub get_installed_machine_version {
- my ($kvmversion) = @_;
- $kvmversion = kvm_user_version() if !defined($kvmversion);
- $kvmversion =~ m/^(\d+\.\d+)/;
- return $1;
-}
-
sub windows_get_pinned_machine_version {
my ($machine, $base_version, $kvmversion) = @_;
@@ -3285,7 +3278,7 @@ sub windows_get_pinned_machine_version {
if (!defined($base_version) ||
!PVE::QemuServer::Machine::can_run_pve_machine_version($base_version, $kvmversion)
) {
- $pin_version = get_installed_machine_version($kvmversion);
+ $pin_version = PVE::QemuServer::Machine::get_installed_machine_version($kvmversion);
}
if (!$machine || $machine eq 'pc') {
$machine = "pc-i440fx-$pin_version";
diff --git a/PVE/QemuServer/Machine.pm b/PVE/QemuServer/Machine.pm
index 5a039244..075554f4 100644
--- a/PVE/QemuServer/Machine.pm
+++ b/PVE/QemuServer/Machine.pm
@@ -186,4 +186,11 @@ sub qemu_machine_pxe {
return $machine;
}
+sub get_installed_machine_version {
+ my ($kvmversion) = @_;
+ $kvmversion = PVE::QemuServer::Helpers::kvm_user_version() if !defined($kvmversion);
+ $kvmversion =~ m/^(\d+\.\d+)/;
+ return $1;
+}
+
1;
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-01-17 12:09 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-17 12:07 [pve-devel] [PATCH qemu/qemu-server/docs v3 00/18] adapt to changes in QEMU machine version deprecation/removal Fiona Ebner
2025-01-17 12:08 ` [pve-devel] [PATCH qemu v3 01/18] adapt machine version deprecation for Proxmox VE Fiona Ebner
2025-01-17 13:10 ` [pve-devel] applied: " Thomas Lamprecht
2025-01-17 12:08 ` [pve-devel] [PATCH qemu-server v3 02/18] machine: drop unused parameter from assert_valid_machine_property() helper Fiona Ebner
2025-01-17 12:08 ` [pve-devel] [PATCH qemu-server v3 03/18] move get_command_for_arch() helper to helpers module Fiona Ebner
2025-01-17 12:08 ` [pve-devel] [PATCH qemu-server v3 04/18] helpers: improve name for variable for mapping arch to binary Fiona Ebner
2025-01-17 12:08 ` [pve-devel] [PATCH qemu-server v3 05/18] move kvm_user_version() function to helpers module Fiona Ebner
2025-01-17 12:08 ` [pve-devel] [PATCH qemu-server v3 06/18] move get_vm_arch() helper " Fiona Ebner
2025-01-17 12:08 ` [pve-devel] [PATCH qemu-server v3 07/18] machine: add default_machine_for_arch() helper Fiona Ebner
2025-01-17 12:08 ` Fiona Ebner [this message]
2025-01-17 12:08 ` [pve-devel] [PATCH qemu-server v3 09/18] move windows_get_pinned_machine_version() function to machine module Fiona Ebner
2025-01-17 12:08 ` [pve-devel] [PATCH qemu-server v3 10/18] move get_vm_machine() " Fiona Ebner
2025-01-17 12:08 ` [pve-devel] [PATCH qemu-server v3 11/18] move meta information handling to its own module Fiona Ebner
2025-01-17 12:08 ` [pve-devel] [PATCH qemu-server v3 12/18] machine: fallback to creation QEMU version for windows starting with 9.1 Fiona Ebner
2025-01-17 12:08 ` [pve-devel] [PATCH qemu-server v3 13/18] machine: add check_and_pin_machine_string() helper Fiona Ebner
2025-01-17 12:08 ` [pve-devel] [PATCH qemu-server v3 14/18] api: update vm config: pin machine version when switching to windows os type Fiona Ebner
2025-01-17 12:08 ` [pve-devel] [PATCH qemu-server v3 15/18] machine: log informational line when pinning machine version for Windows guest Fiona Ebner
2025-01-17 12:08 ` [pve-devel] [PATCH qemu-server v3 16/18] machine: rename machine_version() function to machine_version_at_least() Fiona Ebner
2025-01-17 12:08 ` [pve-devel] [PATCH qemu-server v3 17/18] machine: code cleanup: avoid superfluous augmented assignment operator Fiona Ebner
2025-01-17 12:08 ` [pve-devel] [PATCH docs v3 18/18] qm: machine version: document support in PVE Fiona Ebner
2025-01-17 13:09 ` [pve-devel] [PATCH qemu/qemu-server/docs v3 00/18] adapt to changes in QEMU machine version deprecation/removal Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250117120817.41443-9-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox